Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Commit e6309a3

Browse files
crankydillomanub
authored andcommitted
Remove the coupling with ScalaTest (#146)
1 parent 55cb334 commit e6309a3

File tree

6 files changed

+1
-11
lines changed

6 files changed

+1
-11
lines changed

‎build.sbt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@ lazy val commonSettings = Seq(
2121

2222
lazy val commonLibrarySettings = libraryDependencies ++= Seq(
2323
"org.apache.avro" % "avro" % "1.8.1",
24-
"org.scalatest" %% "scalatest" % "3.0.5",
2524
"org.apache.kafka" %% "kafka" % kafkaVersion,
25+
"org.scalatest" %% "scalatest" % "3.0.5" % Test,
2626
"com.typesafe.akka" %% "akka-actor" % akkaVersion % Test,
2727
"com.typesafe.akka" %% "akka-testkit" % akkaVersion % Test
2828
)

‎embedded-kafka/src/main/scala/net/manub/embeddedkafka/EmbeddedKafka.scala‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ import org.apache.kafka.common.serialization.{
2424
}
2525
import org.apache.kafka.common.{KafkaException, TopicPartition}
2626
import org.apache.zookeeper.server.{ServerCnxnFactory, ZooKeeperServer}
27-
import org.scalatest.Suite
2827

2928
import scala.collection.JavaConverters._
3029
import scala.collection.mutable.ListBuffer
@@ -34,7 +33,6 @@ import scala.reflect.io.Directory
3433
import scala.util.Try
3534

3635
trait EmbeddedKafka extends EmbeddedKafkaSupport[EmbeddedKafkaConfig] {
37-
this: Suite =>
3836

3937
override def baseConsumerConfig(
4038
implicit config: EmbeddedKafkaConfig): Map[String, Object] =

‎kafka-streams/src/main/scala/net/manub/embeddedkafka/streams/EmbeddedKafkaStreams.scala‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,14 +2,12 @@ package net.manub.embeddedkafka.streams
22

33
import net.manub.embeddedkafka.{EmbeddedKafka, EmbeddedKafkaConfig, UUIDs}
44
import org.apache.kafka.streams.{KafkaStreams, Topology}
5-
import org.scalatest.Suite
65

76
/** Helper trait for testing Kafka Streams.
87
* It creates an embedded Kafka Instance for each test case.
98
* Use `runStreams` to execute your streams.
109
*/
1110
trait EmbeddedKafkaStreams extends EmbeddedKafka with TestStreamsConfig {
12-
this: Suite =>
1311

1412
/** Execute Kafka streams and pass a block of code that can
1513
* operate while the streams are active.

‎kafka-streams/src/main/scala/net/manub/embeddedkafka/streams/EmbeddedKafkaStreamsAllInOne.scala‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ package net.manub.embeddedkafka.streams
33
import net.manub.embeddedkafka.{Consumers, EmbeddedKafkaConfig}
44
import org.apache.kafka.clients.consumer.KafkaConsumer
55
import org.apache.kafka.streams.Topology
6-
import org.scalatest.Suite
76

87
/** Convenience trait for testing Kafka Streams with ScalaTest.
98
* It exposes `EmbeddedKafkaStreams.runStreams` as well as `Consumers` api
@@ -13,7 +12,6 @@ import org.scalatest.Suite
1312
* @see [[EmbeddedKafkaStreams]]
1413
*/
1514
trait EmbeddedKafkaStreamsAllInOne extends EmbeddedKafkaStreams with Consumers {
16-
this: Suite =>
1715

1816
/** Run Kafka Streams while offering a String-based consumer for easy testing of stream output.
1917
*

‎schema-registry/src/main/scala/net.manub.embeddedkafka/schemaregistry/streams/EmbeddedKafkaStreamsWithSchemaRegistry.scala‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ import net.manub.embeddedkafka.schemaregistry.{
88
}
99
import net.manub.embeddedkafka.streams.TestStreamsConfig
1010
import org.apache.kafka.streams.{KafkaStreams, Topology}
11-
import org.scalatest.Suite
1211

1312
// TODO: need to find a better way of not duplicating this code from the kafka-streams module
1413

@@ -19,7 +18,6 @@ import org.scalatest.Suite
1918
trait EmbeddedKafkaStreamsWithSchemaRegistry
2019
extends EmbeddedKafkaWithSchemaRegistry
2120
with TestStreamsConfig {
22-
this: Suite =>
2321

2422
/** Execute Kafka streams and pass a block of code that can
2523
* operate while the streams are active.

‎schema-registry/src/main/scala/net.manub.embeddedkafka/schemaregistry/streams/EmbeddedKafkaStreamsWithSchemaRegistryAllInOne.scala‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ import net.manub.embeddedkafka.Consumers
44
import net.manub.embeddedkafka.schemaregistry.EmbeddedKafkaConfigWithSchemaRegistry
55
import org.apache.kafka.clients.consumer.KafkaConsumer
66
import org.apache.kafka.streams.Topology
7-
import org.scalatest.Suite
87

98
// TODO: need to find a better way of not duplicating this code from the kafka-streams module
109

@@ -18,7 +17,6 @@ import org.scalatest.Suite
1817
trait EmbeddedKafkaStreamsWithSchemaRegistryAllInOne
1918
extends EmbeddedKafkaStreamsWithSchemaRegistry
2019
with Consumers {
21-
this: Suite =>
2220

2321
/** Run Kafka Streams while offering a String-based consumer for easy testing of stream output.
2422
*

0 commit comments

Comments
(0)

AltStyle によって変換されたページ (->オリジナル) /