Commit ace1d83

authored

Stopping Zookeeper on EmbeddedKafka.stop() (#152)

Fixes #150

1 parent 890e34c commit ace1d83Copy full SHA for ace1d83

File tree

-3

lines changed

-3

lines changed

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -79,7 +79,8 @@ object EmbeddedKafka extends EmbeddedKafkaSupport[EmbeddedKafkaConfig] {`
`79`	`79`	`val broker =`
`80`	`80`	`EmbeddedK(Option(factory), kafkaServer, kafkaLogsDir, actualConfig)`
`81`	`81`
`82`		`- servers :+= broker`
	`82`	`+ servers ++= Seq(broker, factory)`
	`83`	`+`
`83`	`84`	`broker`
`84`	`85`	`}`
`85`	`86`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ case class EmbeddedZ(factory: ServerCnxnFactory, logsDirs: Directory)(`
`29`	`29`	`*`
`30`	`30`	* @param clearLogs pass `true` to recursively delete the log directory.
`31`	`31`	`*/`
`32`		`- override def stop(clearLogs: Boolean) = {`
	`32`	`+ override def stop(clearLogs: Boolean):Unit = {`
`33`	`33`	`factory.shutdown()`
`34`	`34`	`if (clearLogs) logsDirs.deleteRecursively()`
`35`	`35`	`}`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@ class EmbeddedKafkaObjectSpec extends EmbeddedKafkaSpecSupport {`
`30`	`30`	`}`
`31`	`31`
`32`	`32`	`"start and stop Kafka and Zookeeper on different specified ports using an implicit configuration" in {`
`33`		`- implicit val config =`
	`33`	`+ implicit val config:EmbeddedKafkaConfig =`
`34`	`34`	`EmbeddedKafkaConfig(kafkaPort = 12345, zooKeeperPort = 54321)`
`35`	`35`	`EmbeddedKafka.start()`
`36`	`36`

Comments

(0)