Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commit 90a3fe2

Browse files
committed
Merge branch 'v4.1'
2 parents c7eab61 + 8e04b67 commit 90a3fe2

File tree

2 files changed

+9
-4
lines changed

2 files changed

+9
-4
lines changed

‎CHANGELOG.md‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,12 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
1717
- Updated PHP requirement from `^7.0` to `^7.1`
1818
- Updated `phpspec/phpspec` dependency from `~4.0` to `^4.2`
1919

20+
## [4.1.2] - 2018年03月21日
21+
22+
- Fix `--no-coverage` option introducing errors when running non `run` commands.
23+
- `--no-coverage` option is now available to all phpspec commands (not only
24+
`run`). (#30)
25+
2026
## [4.1.1] - 2018年03月19日
2127

2228
- Added `--no-coverage` option which can skip code coverage generation during
@@ -92,6 +98,7 @@ as [leanphp/phpspec-code-coverage][0].
9298
reports (`blaclist_files` option).
9399

94100
[4.2.0]: https://github.com/leanphp/phpspec-code-coverage/releases/tag/v4.2.0
101+
[4.1.2]: https://github.com/leanphp/phpspec-code-coverage/releases/tag/v4.1.2
95102
[4.1.1]: https://github.com/leanphp/phpspec-code-coverage/releases/tag/v4.1.1
96103
[4.1.0]: https://github.com/leanphp/phpspec-code-coverage/releases/tag/v4.1.0
97104
[4.0.0]: https://github.com/leanphp/phpspec-code-coverage/releases/tag/v4.0.0

‎src/CodeCoverageExtension.php‎

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -35,9 +35,7 @@ class CodeCoverageExtension implements Extension
3535
public function load(ServiceContainer $container, array $params = [])
3636
{
3737
foreach ($container->getByTag('console.commands') as $command) {
38-
if ($command->getName() === 'run') {
39-
$command->addOption('no-coverage', null, InputOption::VALUE_NONE, 'Skip code coverage generation');
40-
}
38+
$command->addOption('no-coverage', null, InputOption::VALUE_NONE, 'Skip code coverage generation');
4139
}
4240

4341
$container->define('code_coverage.filter', function () {
@@ -118,7 +116,7 @@ public function load(ServiceContainer $container, array $params = [])
118116

119117
$skipCoverage = false;
120118
$input = $container->get('console.input');
121-
if ($input->getOption('no-coverage')) {
119+
if ($input->hasOption('no-coverage') && $input->getOption('no-coverage')) {
122120
$skipCoverage = true;
123121
}
124122

0 commit comments

Comments
(0)

AltStyle によって変換されたページ (->オリジナル) /