Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Update README.md #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
userlond wants to merge 1 commit into kylefox:master from userlond:patch-1
Closed

Update README.md #205

userlond wants to merge 1 commit into kylefox:master from userlond:patch-1

Conversation

@userlond
Copy link

@userlond userlond commented Jun 22, 2017

I use jquery.modal version 0.8.0.
Why I've made changes in readme is in the code section below.

$('#container').on($.modal.BEFORE_OPEN, function(event, modal) {
 // prints undefined
 console.log(modal.$elm); 
 // without dollar sign it works
 console.log(modal.elm);
 // blocker works with dollar sign 
 console.log(modal.$blocker);
});

Maybe it will be ok to skip this request prior to some twiks in code to unify properties name (i.e. make working modal.$elm and modal.$blocker (or modal.elm and modal.blocker)).

I use jquery.modal version 0.8.0.
Why I've made changes in readme is in the code section below.
$('#container').on($.modal.BEFORE_OPEN, function(event, modal) {
 // prints undefined
 console.log(modal.$elm); 
 // without dollar sign it works
 console.log(modal.elm);
 // blocker works with dollar sign 
 console.log(modal.$blocker);
});
Maybe it will be ok to skip this request prior to some twiks in code to unify properties name (i.e. make working modal.$elm and modal.$blocker (or modal.elm and modal.blocker)).
Copy link
Owner

kylefox commented Jul 3, 2017

Thanks for pointing this out — I actually stumbled across this exact issue myself today!

To fix without breaking backwards compatibility, I simply aliased modal.$elm and modal.elm — they will both work as of version 0.8.1.

userlond and gorillamoe reacted with thumbs up emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

AltStyle によって変換されたページ (->オリジナル) /