-
Notifications
You must be signed in to change notification settings - Fork 303
🌱 Removed disabled usetesting in golangci.yaml, fixing linting issues #3503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign enxebre for approval. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Hi @PatrickLaabs. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
/test pull-cluster-api-provider-vsphere-e2e-vcsim-supervisor-main
@sbueringer Shall I also investigate, if we are able to remove 'ctrl.SetupSignalHandler()' for the vsphere provider?
@sbueringer Shall I also investigate, if we are able to remove 'ctrl.SetupSignalHandler()' for the vsphere provider?
I think the answer should be the same as for core CAPI. I would just like to figure out our policy via core CAPI and then align here
(I'm very very low on bandwidth at the moment, we're trying to finish v1beta2 in time..)
No Problem. I guess this fix isn't critical for the next release, therefore it can wait a little longer 😄
Is there anything I can help you with for the v1beta2 release?
No Problem. I guess this fix isn't critical for the next release, therefore it can wait a little longer 😄 Is there anything I can help you with for the v1beta2 release?
Thx for offering. Not sure. v1beta2 for CAPV won't be done in v1.14. I think in core CAPI we only have the pretty complicated and big tasks remaining
k8s-triage-robot
commented
Sep 15, 2025
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closed
You can:
- Mark this PR as fresh with
/remove-lifecycle stale - Close this PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
/remove-lifecycle stale
What this PR does / why we need it:
After the PR #3469 has been merged, I removed the disabled "usetesting" in the config file, and fixed all the various linting issues that came across.
Mostly, it has been replacements of
context.Background()tot.Context()and a fewos.CreateTemp("", ...)toos.CreateTemp(t.TempDir(), ...)Which issue(s) this PR fixes:
Fixes #3470