-
Notifications
You must be signed in to change notification settings - Fork 15
add MachineHealthCheck #146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
1027173
6b97a24
825caaa
48988a4
7246652
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
- Loading branch information
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,4 @@ | ||
| apiVersion: kustomize.config.k8s.io/v1beta1 | ||
| kind: Kustomization | ||
| namespace: default | ||
| resources: | ||
| - cluster-template.yaml |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| apiVersion: kustomize.config.k8s.io/v1beta1 | ||
| kind: Kustomization | ||
| resources: | ||
| - ../../base | ||
| - machinehealthcheck.yaml |
3deep5me marked this conversation as resolved.
Show resolved
Hide resolved
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| apiVersion: cluster.x-k8s.io/v1beta1 | ||
| kind: MachineHealthCheck | ||
| metadata: | ||
| name: ${CLUSTER_NAME}-unhealthy-5m | ||
3deep5me marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| spec: | ||
| clusterName: '${CLUSTER_NAME}' | ||
| nodeStartupTimeout: 5m | ||
| maxUnhealthy: 100% | ||
| selector: | ||
| matchLabels: | ||
| cluster.x-k8s.io/cluster-name: '${CLUSTER_NAME}' | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. is this a good idea to have single mhc for all the nodes in a cluster ? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It think its more common to have two mhc but in the simple setup i see no reason for that. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. To be precise, I don't know how the two mhc should differ. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. https://cluster-api.sigs.k8s.io/tasks/automated-machine-management/healthchecking.html#creating-a-machinehealthcheck There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Mhhhh... okay. But the Examples do not differ. But we can definitely do two mhc if you want to be more cluster-api conformant. |
||
| unhealthyConditions: | ||
| - type: Ready | ||
| status: Unknown | ||
| timeout: 300s | ||
| - type: Ready | ||
| status: "False" | ||
| timeout: 300s | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| apiVersion: kustomize.config.k8s.io/v1beta1 | ||
| kind: Kustomization | ||
| resources: | ||
| - ../../base |