-
Notifications
You must be signed in to change notification settings - Fork 690
Fix missing dependency on packaging
#590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This package has been required since deprecation of `distutils`
@coox Thanks for your reporting.
Is there a problem running or a problem installing it?
can you describe pg_chameleon pip install version
when I try to install latest version 2.0.19, i did not �found the error.
pip install pg-chameleon==2.0.19
Collecting pg-chameleon==2.0.19
Downloading pg_chameleon-2.0.19-py3-none-any.whl (107 kB)
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 107.1/107.1 kB 3.7 MB/s eta 0:00:00
Requirement already satisfied: PyMySQL>=0.10.0 in ./opt/anaconda3/envs/python-mysql-replication/lib/python3.9/site-packages (from pg-chameleon==2.0.19) (1.1.0)
Collecting mysql-replication>=0.31 (from pg-chameleon==2.0.19)
Using cached mysql_replication-1.0.4-py3-none-any.whl
Collecting psycopg2-binary>=2.8.3 (from pg-chameleon==2.0.19)
Downloading psycopg2_binary-2.9.9-cp39-cp39-macosx_10_9_x86_64.whl (2.8 MB)
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 2.8/2.8 MB 11.1 MB/s eta 0:00:00
Requirement already satisfied: PyYAML>=3.13 in ./opt/anaconda3/envs/python-mysql-replication/lib/python3.9/site-packages (from pg-chameleon==2.0.19) (6.0.1)
Collecting tabulate>=0.8.1 (from pg-chameleon==2.0.19)
Downloading tabulate-0.9.0-py3-none-any.whl (35 kB)
Collecting daemonize>=2.4.7 (from pg-chameleon==2.0.19)
Downloading daemonize-2.5.0-py2.py3-none-any.whl (5.2 kB)
Collecting rollbar>=0.13.17 (from pg-chameleon==2.0.19)
Downloading rollbar-1.0.0-py3-none-any.whl (101 kB)
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 101.2/101.2 kB 4.3 MB/s eta 0:00:00
Requirement already satisfied: requests>=0.12.1 in ./opt/anaconda3/envs/python-mysql-replication/lib/python3.9/site-packages (from rollbar>=0.13.17->pg-chameleon==2.0.19) (2.31.0)
Requirement already satisfied: charset-normalizer<4,>=2 in ./opt/anaconda3/envs/python-mysql-replication/lib/python3.9/site-packages (from requests>=0.12.1->rollbar>=0.13.17->pg-chameleon==2.0.19) (3.3.0)
Requirement already satisfied: idna<4,>=2.5 in ./opt/anaconda3/envs/python-mysql-replication/lib/python3.9/site-packages (from requests>=0.12.1->rollbar>=0.13.17->pg-chameleon==2.0.19) (3.4)
Requirement already satisfied: urllib3<3,>=1.21.1 in ./opt/anaconda3/envs/python-mysql-replication/lib/python3.9/site-packages (from requests>=0.12.1->rollbar>=0.13.17->pg-chameleon==2.0.19) (2.0.6)
Requirement already satisfied: certifi>=2017年4月17日 in ./opt/anaconda3/envs/python-mysql-replication/lib/python3.9/site-packages (from requests>=0.12.1->rollbar>=0.13.17->pg-chameleon==2.0.19) (2023年7月22日)
Installing collected packages: daemonize, tabulate, psycopg2-binary, mysql-replication, rollbar, pg-chameleon
Successfully installed daemonize-2.5.0 mysql-replication-1.0.4 pg-chameleon-2.0.19 psycopg2-binary-2.9.9 rollbar-1.0.0 tabulate-0.9.0
@coox Thanks for your reporting. Is there a problem running or a problem installing it? can you describe pg_chameleon pip install version
when I try to install latest version 2.0.19, i did not �found the error.
pip install pg-chameleon==2.0.19 Collecting pg-chameleon==2.0.19 Downloading pg_chameleon-2.0.19-py3-none-any.whl (107 kB) ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 107.1/107.1 kB 3.7 MB/s eta 0:00:00 Requirement already satisfied: PyMySQL>=0.10.0 in ./opt/anaconda3/envs/python-mysql-replication/lib/python3.9/site-packages (from pg-chameleon==2.0.19) (1.1.0) Collecting mysql-replication>=0.31 (from pg-chameleon==2.0.19) Using cached mysql_replication-1.0.4-py3-none-any.whl Collecting psycopg2-binary>=2.8.3 (from pg-chameleon==2.0.19) Downloading psycopg2_binary-2.9.9-cp39-cp39-macosx_10_9_x86_64.whl (2.8 MB) ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 2.8/2.8 MB 11.1 MB/s eta 0:00:00 Requirement already satisfied: PyYAML>=3.13 in ./opt/anaconda3/envs/python-mysql-replication/lib/python3.9/site-packages (from pg-chameleon==2.0.19) (6.0.1) Collecting tabulate>=0.8.1 (from pg-chameleon==2.0.19) Downloading tabulate-0.9.0-py3-none-any.whl (35 kB) Collecting daemonize>=2.4.7 (from pg-chameleon==2.0.19) Downloading daemonize-2.5.0-py2.py3-none-any.whl (5.2 kB) Collecting rollbar>=0.13.17 (from pg-chameleon==2.0.19) Downloading rollbar-1.0.0-py3-none-any.whl (101 kB) ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 101.2/101.2 kB 4.3 MB/s eta 0:00:00 Requirement already satisfied: requests>=0.12.1 in ./opt/anaconda3/envs/python-mysql-replication/lib/python3.9/site-packages (from rollbar>=0.13.17->pg-chameleon==2.0.19) (2.31.0) Requirement already satisfied: charset-normalizer<4,>=2 in ./opt/anaconda3/envs/python-mysql-replication/lib/python3.9/site-packages (from requests>=0.12.1->rollbar>=0.13.17->pg-chameleon==2.0.19) (3.3.0) Requirement already satisfied: idna<4,>=2.5 in ./opt/anaconda3/envs/python-mysql-replication/lib/python3.9/site-packages (from requests>=0.12.1->rollbar>=0.13.17->pg-chameleon==2.0.19) (3.4) Requirement already satisfied: urllib3<3,>=1.21.1 in ./opt/anaconda3/envs/python-mysql-replication/lib/python3.9/site-packages (from requests>=0.12.1->rollbar>=0.13.17->pg-chameleon==2.0.19) (2.0.6) Requirement already satisfied: certifi>=2017年4月17日 in ./opt/anaconda3/envs/python-mysql-replication/lib/python3.9/site-packages (from requests>=0.12.1->rollbar>=0.13.17->pg-chameleon==2.0.19) (2023年7月22日) Installing collected packages: daemonize, tabulate, psycopg2-binary, mysql-replication, rollbar, pg-chameleon Successfully installed daemonize-2.5.0 mysql-replication-1.0.4 pg-chameleon-2.0.19 psycopg2-binary-2.9.9 rollbar-1.0.0 tabulate-0.9.0
I meet same issue before. If you uninstall packaging and re-install mysql-replication the problem can be reproduced.
env: python 3.8.10, pip 21.1.1
packaging version can be 23.1
image
@coox @gongyisheng I'll release this problem Thanks
sean-k1
sean-k1
approved these changes
Dec 9, 2023
Thank you @sean-k1 and @gongyisheng!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since the deprecation of
distutils(#574), thepackagingpackage has become a requirement, but was missing from the project’s dependencies.We noticed this when recently attempting to install pg_chameleon, only to end up facing a
ModuleNotFoundError, which we traced back to this unsatisfied dependency.The present Pull Request fixes this by explicitly listing
packagingas a dependency.Type of Change
Checklist
Tests