Commit b706935

authored

cmake: avoid Apple ranlib flags when not using AppleClang (#5258)

On macOS, `-no_warning_for_no_symbols -c` options are specific to the Apple `ranlib` tool. When using other toolchains (e.g. Homebrew clang), these flags cause errors since `llvm-ranlib` does not recognize them. The patch ensures these flags are only passed when using AppleClang. JerryScript-DCO-1.0-Signed-off-by: Renata Hodovan reni@inf.u-szeged.hu

1 parent 355ab24 commit b706935Copy full SHA for b706935

File tree

1 file changed

-1

lines changed

CMakeLists.txt

1 file changed

-1

lines changed

`‎CMakeLists.txt‎`

Lines changed: 5 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -209,7 +209,11 @@ endif()`
`209`	`209`	`if("${PLATFORM}" STREQUAL "DARWIN")`
`210`	`210`	`jerry_add_link_flags(-lSystem)`
`211`	`211`	`set(CMAKE_C_ARCHIVE_CREATE "<CMAKE_AR> Sqc <TARGET> <LINK_FLAGS> <OBJECTS>")`
`212`		`- set(CMAKE_C_ARCHIVE_FINISH "<CMAKE_RANLIB> -no_warning_for_no_symbols -c <TARGET>")`
	`212`	`+ if("${CMAKE_C_COMPILER_ID}" STREQUAL "AppleClang")`
	`213`	`+ set(CMAKE_C_ARCHIVE_FINISH "<CMAKE_RANLIB> -no_warning_for_no_symbols -c <TARGET>")`
	`214`	`+ else()`
	`215`	`+ set(CMAKE_C_ARCHIVE_FINISH "<CMAKE_RANLIB> <TARGET>")`
	`216`	`+ endif()`
`213`	`217`	`set(CMAKE_SHARED_LINKER_FLAGS "-undefined dynamic_lookup")`
`214`	`218`	`elseif((NOT CYGWIN AND NOT MINGW AND NOT MSYS) AND (USING_GCC OR USING_CLANG))`
`215`	`219`	`jerry_add_link_flags(-Wl,-z,noexecstack)`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit b706935

File tree

1 file changed

1 file changed

`‎CMakeLists.txt‎`

0 commit comments