Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commit d1c3d14

Browse files
feat(Response): add setHeader as header fn alias (#265)
1 parent 5a8d2ed commit d1c3d14

File tree

3 files changed

+30
-0
lines changed

3 files changed

+30
-0
lines changed

‎__tests__/headers.unit.js‎

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,13 @@ api.get('/hasHeader', function(req,res) {
9090
})
9191
})
9292

93+
api.get('/setHeader', function(req,res) {
94+
res.status(200).header('TestHeader','test').setHeader('NewHeader','test')
95+
res.json({
96+
headers: res.getHeaders()
97+
})
98+
});
99+
93100
api.get('/removeHeader', function(req,res) {
94101
res.status(200).header('TestHeader','test').header('NewHeader','test').removeHeader('testHeader')
95102
res.json({
@@ -243,6 +250,20 @@ describe('Header Tests:', function() {
243250
})
244251
}) // end it
245252

253+
it('Set Header', async function() {
254+
let _event = Object.assign({},event,{ path: '/setHeader'})
255+
let result = await new Promise(r => api.run(_event,{},(e,res) => { r(res) }))
256+
expect(result).toEqual({
257+
multiValueHeaders: {
258+
'content-type': ['application/json'],
259+
'testheader': ['test'],
260+
'newheader': ['test']
261+
}, statusCode: 200,
262+
body: "{\"headers\":{\"content-type\":[\"application/json\"],\"testheader\":[\"test\"],\"newheader\":[\"test\"]}}",
263+
isBase64Encoded: false
264+
})
265+
}) // end it
266+
246267
it('Remove Header', async function() {
247268
let _event = Object.assign({},event,{ path: '/removeHeader'})
248269
let result = await new Promise(r => api.run(_event,{},(e,res) => { r(res) }))

‎index.d.ts‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -205,6 +205,10 @@ export declare class Response {
205205

206206
getHeader(key: string): string;
207207

208+
getHeaders(): { [key: string]: string };
209+
210+
setHeader(...args: Parameters<typeof this.header>): this;
211+
208212
hasHeader(key: string): boolean;
209213

210214
removeHeader(key: string): this;

‎lib/response.js‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,11 @@ class RESPONSE {
9696
: undefined;
9797
}
9898

99+
// Issue #130
100+
setHeader(...args) {
101+
return this.header(...args);
102+
}
103+
99104
getHeaders() {
100105
return this._headers;
101106
}

0 commit comments

Comments
(0)

AltStyle によって変換されたページ (->オリジナル) /