-
Notifications
You must be signed in to change notification settings - Fork 106
Switch to alpine for image size #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Hopefully this isn't too much like #9, but this switches the image base to Alpine rather than debian to shrink it down. The motivator was that I'm looking to run this as a cron'd sidecar in a Kubernetes deployment, and switching the base along with a couple of bits of layer cleanup drops the image size from 354MB to ~86MB, which is probably a bigger savings than just the layer cleanup bits in #9.
Running it on Alpine required updating the script parser from bash to ash, but everything seems to run fine with that setup. I dropped the FIFO bit as logging to STDOUT seems to be the canonical way to do things in Docker and k8s land.
Feedback welcome :)