-
Notifications
You must be signed in to change notification settings - Fork 13.4k
fix(sheet): disable focus trap with string-based logic #30704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
@ShaneK
ShaneK
force-pushed
the
fix/30700
branch
from
October 2, 2025 13:30
8da777b to
2edab45
Compare
@ShaneK
ShaneK
force-pushed
the
fix/30700
branch
from
October 2, 2025 13:38
2edab45 to
f332f62
Compare
@ShaneK Is this ready for review?
@ShaneK Is this ready for review?
No, it should have been a draft. Fixed that, sorry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #30700
What is the current behavior?
Currently, if you have sheet modals in sub-routes, they have the same breaking app issue that we tried to fix previously: #30689
What is the new behavior?
This change tries to add more support for edge cases around focus traps.
Does this introduce a breaking change?
Other information