-
Notifications
You must be signed in to change notification settings - Fork 13.4k
feat(segment): add keyboard navigation, add selectOnFocus property to control selection follow focus behavior #23590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great! A few small comments, but overall this is a really solid PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionality-wise this looks good to go. One lingering question and a couple docs changes.
Co-authored-by: Liam DeBeasi <liamdebeasi@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! Once the builds pass this is good to merge. Be sure to mark this as a feature since we are adding an API.
I updated the PR title, but you may have to set the commit message yourself when merging.
Uh oh!
There was an error while loading. Please reload this page.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: resolves #23520
What is the new behavior?
ion-segmentnow responds properly to keyboard navigation.Does this introduce a breaking change?