Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Allow configuring max_local_error_reset_streams #2421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tottoto merged 4 commits into hyperium:v0.14.x from alexanderrilee:configure-max-stream-resets
Oct 30, 2025

Conversation

@alexanderrilee
Copy link
Contributor

@alexanderrilee alexanderrilee commented Oct 8, 2025

Motivation

This makes max_local_error_reset_streams configurable. We have an isolated environment where we create and close many (valid) short-lived gRPC streams. We very quickly hit the 1024 limit on stream resets, which initiates a GoAway. During connection recreation, the Python gRPC client misbehaves. We would like the option to tune this limit, since this is a safe traffic pattern for us.

Solution

I've added http2_max_local_error_reset_streams to the Server API.

aldanor and alexanderrilee reacted with thumbs up emoji
Copy link

aldanor commented Oct 17, 2025

Given there's now also references from h2, would it be possible to get this merged? (cc @tottoto perhaps? thanks)
alexanderrilee reacted with thumbs up emoji

Copy link
Collaborator

@tottoto tottoto left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this. I left some comments.

aldanor reacted with thumbs up emoji
Copy link
Contributor Author

I'm not sure why the "CI / Interop Tests (macOS-latest)" test failed, but it looks unrelated?

Copy link
Collaborator

@tottoto tottoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexanderrilee Thanks! Could you squash the commits and upstream it to the default branch? I think I'd like to merge this pull request as a backport of it.

I'm not sure why the "CI / Interop Tests (macOS-latest)" test failed, but it looks unrelated?

Yes. It isn't related to this change.

tottoto pushed a commit that referenced this pull request Oct 30, 2025 
...2437)
Squashed version of #2421 applied
to `master`.
Co-authored-by: alexanderrilee <alexanderrilee@users.noreply.github.com>
@tottoto tottoto merged commit 1cf2297 into hyperium:v0.14.x Oct 30, 2025
58 of 60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tottoto tottoto tottoto approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /