Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Commit f830a1e

Browse files
Change .also to .apply
To make code more concise, which, according to the style guidelines, is more important than being verbose for clarity.
1 parent 38ae22e commit f830a1e

File tree

2 files changed

+15
-15
lines changed

2 files changed

+15
-15
lines changed

‎app/src/main/java/tk/superl2/xwifi/MainActivity.kt‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -69,11 +69,11 @@ class MainActivity: AppCompatActivity() {
6969

7070
wifi_ListView.adapter = ArrayAdapter(this, android.R.layout.simple_list_item_1, wifiEntrySSIDs)
7171
wifi_ListView.setOnItemClickListener { _, _, position, _ ->
72-
qrDialog = AlertDialog.Builder(this).also { builder ->
73-
builder.setView(ImageView(this).also { qrImage ->
74-
qrImage.setPadding(0, 0, 0, QR_CODE_DIALOG_BOTTOM_IMAGE_MARGIN)
75-
qrImage.adjustViewBounds = true
76-
qrImage.setImageBitmap(QRCode
72+
qrDialog = AlertDialog.Builder(this).apply {
73+
setView(ImageView(this@MainActivity).apply {
74+
setPadding(0, 0, 0, QR_CODE_DIALOG_BOTTOM_IMAGE_MARGIN)
75+
adjustViewBounds = true
76+
setImageBitmap(QRCode
7777
.from(Wifi()
7878
.withSsid(wifiEntrySSIDs[position])
7979
.withPsk(wifiEntries[position].password)
@@ -82,7 +82,7 @@ class MainActivity: AppCompatActivity() {
8282
.withSize(prefs.getString("qr_code_resolution", DEFAULT_QR_CODE_RESOLUTION).toInt(), prefs.getString("qr_code_resolution", DEFAULT_QR_CODE_RESOLUTION).toInt())
8383
.bitmap())
8484
})
85-
builder.setPositiveButton("Done") { dialog, _ -> dialog.dismiss() }
85+
setPositiveButton("Done") { dialog, _ -> dialog.dismiss() }
8686
}.create()
8787
qrDialog.show()
8888
}

‎app/src/main/java/tk/superl2/xwifi/xposed/XposedModule.kt‎

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -130,23 +130,23 @@ class XposedModule: IXposedHookLoadPackage {
130130
try {
131131
val prefs = RemotePreferences(AndroidAppHelper.currentApplication(), "tk.superl2.xwifi.preferences", "tk.superl2.xwifi_preferences")
132132
val selectedAccessPoint = searchForWifiEntry(getObjectField(getObjectField(param.thisObject, "mSelectedAccessPoint"), "ssid") as String, getObjectField(getObjectField(param.thisObject, "mSelectedAccessPoint"), "security") as Int)
133-
AlertDialog.Builder((param.thisObject as Fragment).activity).also { builder ->
134-
builder.setTitle(selectedAccessPoint.title)
135-
builder.setView(ImageView((param.thisObject as Fragment).activity).also { qrCodeView ->
136-
qrCodeView.setPadding(0, 0, 0, QR_CODE_DIALOG_BOTTOM_IMAGE_MARGIN)
137-
qrCodeView.adjustViewBounds = true
138-
qrCodeView.setImageBitmap(QRCode
133+
AlertDialog.Builder((param.thisObject as Fragment).activity).apply {
134+
setTitle(selectedAccessPoint.title)
135+
setView(ImageView((param.thisObject as Fragment).activity).apply {
136+
setPadding(0, 0, 0, QR_CODE_DIALOG_BOTTOM_IMAGE_MARGIN)
137+
adjustViewBounds = true
138+
setImageBitmap(QRCode
139139
.from(Wifi()
140140
.withSsid(selectedAccessPoint.title)
141141
.withPsk(selectedAccessPoint.password)
142142
.withAuthentication(selectedAccessPoint.type.asQRCodeAuth()))
143143
.withSize(prefs.getString("qr_code_resolution", DEFAULT_QR_CODE_RESOLUTION).toInt(), prefs.getString("qr_code_resolution", DEFAULT_QR_CODE_RESOLUTION).toInt())
144144
.bitmap())
145145
})
146-
builder.setNeutralButton("Settings") { dialog, _ -> dialog.dismiss(); (param.thisObject as Fragment).startActivity(Intent().setComponent(ComponentName("tk.superl2.xwifi", "tk.superl2.xwifi.SettingsActivity")).putExtra("xposed", true)) }
147-
builder.setPositiveButton("Done") { dialog, _ -> dialog.dismiss() }
146+
setNeutralButton("Settings") { dialog, _ -> dialog.dismiss(); (param.thisObject as Fragment).startActivity(Intent().setComponent(ComponentName("tk.superl2.xwifi", "tk.superl2.xwifi.SettingsActivity")).putExtra("xposed", true)) }
147+
setPositiveButton("Done") { dialog, _ -> dialog.dismiss() }
148148
loadingDialog.dismiss()
149-
(param.thisObject as Fragment).activity.runOnUiThread { builder.show() }
149+
(param.thisObject as Fragment).activity.runOnUiThread { show() }
150150
}
151151
} catch (e: WifiUnparseableException) {
152152
AlertDialog.Builder((param.thisObject as Fragment).activity).apply {

0 commit comments

Comments
(0)

AltStyle によって変換されたページ (->オリジナル) /