This repository was archived by the owner on Oct 3, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Add the @IntRange annotation to requestCode to prevent invalid input #325
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...llegalArgumentException: Can only use lower 16 bits for requestCode
...llegalArgumentException: Can only use lower 16 bits for requestCode
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
📝 Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.
What to do if you already signed the CLA
Individual signers
- It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
Corporate signers
- Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
- The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
- The email used to register you as an authorized contributor must also be attached to your GitHub account.
i️ Googlers: Go here for more info.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
📝 Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with
@googlebot I signed it!and we'll verify it.What to do if you already signed the CLA
Individual signers
- It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
Corporate signers
- Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
- The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
- The email used to register you as an authorized contributor must also be attached to your GitHub account.
i️ Googlers: Go here for more info.
@googlebot I signed it!
samtstern
samtstern
approved these changes
Apr 26, 2021
@PengfeiGao thank you! This seems like a good change.
vmadalin
added a commit
to vmadalin/easypermissions-ktx
that referenced
this pull request
May 4, 2021
* Put in defense for issue 278 (googlesamples#290) * Updating project to support Android Studio 4.0 (googlesamples#307) * Updating module 'app' to Java 8 syntax (googlesamples#308) * Changed getContext() to requireContext(), to ensure it is not null. (googlesamples#309) * Add link to easypermissions-ktx * Move from JCenter to Maven Central (googlesamples#323) * Add the @IntRange annotation to requestCode to prevent invalid input (googlesamples#325) Co-authored-by: gaopengfei <gaopengfei@huobi.com> * Move to GitHub Actions (googlesamples#326) * Start migrating project to maven central * Fix build * Update with correct maven central links Co-authored-by: Sam Stern <samstern@google.com> Co-authored-by: Fung <seventhmoon@gmail.com> Co-authored-by: Fung <chofung@google.com> Co-authored-by: coder1024 <gaopengfeidev@gmail.com> Co-authored-by: gaopengfei <gaopengfei@huobi.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the requestCode is not valid lead to FragmentActivity java.lang.IllegalArgumentException: Can only use lower 16 bits for requestCode