Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: added 'enable_granular_consent' parameter #2582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alebedev80 wants to merge 4 commits into googleapis:main
base: main
Choose a base branch
Loading
from alebedev80:main

Conversation

@alebedev80
Copy link

@alebedev80 alebedev80 commented Mar 22, 2024

I have found that in SDK missed parameter enable_granular_consent. I've added this parameters to Client's configuration. Please review.

@alebedev80 alebedev80 requested a review from a team as a code owner March 22, 2024 08:04
Copy link

google-cla bot commented Mar 22, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link

conventional-commit-lint-gcf bot commented Mar 22, 2024
edited
Loading

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@alebedev80 alebedev80 changed the title (削除) Add 'enable_granular_consent' parameter (削除ここまで) (追記) Added 'enable_granular_consent' parameter (追記ここまで) Mar 22, 2024
@alebedev80 alebedev80 changed the title (削除) Added 'enable_granular_consent' parameter (削除ここまで) (追記) fix: added 'enable_granular_consent' parameter (追記ここまで) Mar 22, 2024
Copy link
Contributor

@bshaffer bshaffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems good but, I can't find any documentation on the Google auth side regarding the enable_granular_consent parameter. Can you show me where you see this documented, so I can be sure it's correct?

Comment on lines +3 to +8
## [2.15.4](https://github.com/googleapis/google-api-php-client/compare/v2.15.3...v2.15.4) (2024年03月22日)

### Features

* Add parameter `enable_granular_consent`

Copy link
Contributor

@bshaffer bshaffer May 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changelog gets updated automatically through our release-please bot. We can revert this change.

Suggested change
## [2.15.4](https://github.com/googleapis/google-api-php-client/compare/v2.15.3...v2.15.4) (2024年03月22日)
### Features
* Add parameter `enable_granular_consent`

? null
: var_export($this->config['include_granted_scopes'], true);


Copy link
Contributor

@bshaffer bshaffer May 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

Copy link

Tuanis commented May 2, 2024

Here's one link to documentation regarding the enable_granular_consent parameter

alebedev80 reacted with thumbs up emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bshaffer bshaffer bshaffer left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /