Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

buildifier integration no longer reports errors correctly #103

Closed
Assignees
Labels
@malcolmr

Description

The changes for #100 broke the way that buildifier reports errors, because we assume that the filename is called "stdin", and after #101, it's the value of -path:

https://github.com/google/vim-codefmt/blob/4b6cb67/autoload/codefmt/buildifier.vim#L57

This results in e.g.

Error formatting file: ERROR(ShellError): Error running: buildifier -path /home/malcolmr/foo/bar/BUILD
/home/malcolmr/foo/bar/BUILD:112:13: syntax error near cc_library

Metadata

Metadata

Labels

Type

No type

Projects

No projects

Milestone

No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      AltStyle によって変換されたページ (->オリジナル) /