-
Notifications
You must be signed in to change notification settings - Fork 2.2k
feat! Add IssueListByOrgOptions and update ListByOrg to use it
#3694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cc @gmlewis
Just FYI - I lost write access to this repo and this may cause unexpected delays for which I apologize.
You can watch that other PR to check on the status.
no worries, thanks for the heads up
@gmlewis hello any updates on your permission?
thanks, that is sad :(
IssueListByRepoOptions and update ListByOrg to use it (追記ここまで)
IssueListByRepoOptions and update ListByOrg to use it (削除ここまで)IssueListByOrgOptions and update ListByOrg to use it (追記ここまで)
@cpanato - do you have time to resolve conflicts in this PR, or would you rather I do that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @cpanato!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging. (Either you or I could resolve conflicts as previously mentioned.)
@stevehipwell and/or @alexandear - might you have time for a code review? Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
...pe filter as well Signed-off-by: Carlos Panato <ctadeu@gmail.com>
547953f to
99e98f3
Compare
@gmlewis PTAL,rebased
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After the change, listIssues is used only in the IssuesService.List. So, let's merge listIssues and List functions.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@ ## master #3694 +/- ## ========================================== - Coverage 91.12% 91.11% -0.02% ========================================== Files 187 187 Lines 16640 16655 +15 ========================================== + Hits 15164 15176 +12 - Misses 1291 1293 +2 - Partials 185 186 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Uh oh!
There was an error while loading. Please reload this page.
BREAKING CHANGE:
ListByOrgnow usesIssueListByOrgOptionsinstead ofListOptions.we now can pass the
Typeof an issue to list issues for repo and orgs, so we can have a better filteringhttps://docs.github.com/en/rest/issues/issues?apiVersion=2022年11月28日#list-repository-issues