This repository was archived by the owner on Aug 5, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Fix memory leak in Patch in Objective-C version #156
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The NSMutableArray being assigned to Patch.diffs isn't being autoreleased correctly. Since it's being assigned to a synthesized property marked with retain, and the NSMutableArray is being initialized with alloc-init, the array needs to be autoreleased so that it doesn't leak.
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
View this failed invocation of the CLA check for more information.
For the most up to date status, view the checks section at the bottom of the pull request.
dmsnell
pushed a commit
to dmsnell/diff-match-patch
that referenced
this pull request
Mar 22, 2024
Resolves google#156. The NSMutableArray being assigned to Patch.diffs isn't being autoreleased correctly. Since it's being assigned to a synthesized property marked with retain, and the NSMutableArray is being initialized with alloc-init, the array needs to be autoreleased so that it doesn't leak. See also Simperium/simperium-ios#89 Authored-by: Anthony Drendel <atdrendel@users.noreply.github.com>
dmsnell
commented
Mar 22, 2024
@atdrendel with @jleandroperez' help I found that we applied an identical patch back in 2013
Simperium/simperium-ios@685c16d
Seems to have been working since then. I've applied this to my fork, which I'm trying to maintain now since this repo is hibernating.
samrayner
pushed a commit
to samrayner/diff-match-patch
that referenced
this pull request
May 6, 2024
Resolves google/diff-match-patch#156. The NSMutableArray being assigned to Patch.diffs isn't being autoreleased correctly. Since it's being assigned to a synthesized property marked with retain, and the NSMutableArray is being initialized with alloc-init, the array needs to be autoreleased so that it doesn't leak. See also Simperium/simperium-ios#89 Authored-by: Anthony Drendel <atdrendel@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
NSMutableArraybeing assigned toPatch.diffsisn't being autoreleased correctly. Since it's being assigned to a synthesized property marked with retain, and theNSMutableArrayis being initialized with alloc-init, the array needs to be autoreleased so that it doesn't leak.