Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Correcting a little error on pt-BR.po #2778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Gabriel-Sousa-Amorim wants to merge 2 commits into google:main
base: main
Choose a base branch
Loading
from Gabriel-Sousa-Amorim:patch-1

Conversation

@Gabriel-Sousa-Amorim
Copy link

@Gabriel-Sousa-Amorim Gabriel-Sousa-Amorim commented Jun 18, 2025
edited
Loading

Hello Everyone!
Correcting little error, that do not translate to Brazilian Portuguese in po/pt-BR.po, adding a sentence in the end of the string for correct translation...

--- msgid "This segment should take about 15 minutes"
--- msgstr "Este segmento deve durar cerca de 15 minutos"
+++ msgid "This segment should take about 15 minutes. It contains:"
+++ msgstr "Este segmento deve durar cerca de 15 minutos. E possui:"

The correction is related with the following issue:

#2777

Correcting little error, that do not translate the msgid: "This segment should take about 15 minutes. It contains:"
Copy link

google-cla bot commented Jun 18, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Author

Hello,
I added more corrections for translating all remaining similar messages that were not translated yet.

Copy link
Collaborator

The CI suggests looking at https://github.com/google/comprehensive-rust/blob/main/TRANSLATIONS.md#creating-and-updating-translations -- I think there's a bit more to do here?

@gribozavr gribozavr added the waiting for author Waiting on the issue author to reply label Jul 25, 2025
Copy link
Collaborator

@Gabriel-Sousa-Amorim We appreciate your contribution, but the moment it is not possible to merge this PR. Please take a look at the logs of the failing checks and the instructions provided by @djmitche above.

Copy link
Collaborator

mgeisler commented Sep 1, 2025

Hey @Gabriel-Sousa-Amorim, the check that prevents this PR from being merged is a bit... terse! But let me explain: it simply requires you to update the pt-BR.po file using Refreshing an Existing Translation.

This means that you must

  • Install the project tools: cargo xtask install-tools (you probably already did this)
  • Build the book: mdbook build (I guess you did this too)
  • Merge the fresh book/xgettext/messages.pot file into po/pt-BR.po (you did not do this)

This is all: you will know that you've done it correctly when you see the POT-Creation-Date header change. It's currently set to

"POT-Creation-Date: 2024年07月09日T12:20:23-07:00\n"

The CI script simply checks that this line changes when any of the msgid fields change (to ensure you build a valid and consistent .po file).

Gabriel-Sousa-Amorim reacted with heart emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rastringer rastringer Awaiting requested review from rastringer rastringer is a code owner

@hugojacob hugojacob Awaiting requested review from hugojacob hugojacob is a code owner

@henrif75 henrif75 Awaiting requested review from henrif75 henrif75 is a code owner

@joaovicmendes joaovicmendes Awaiting requested review from joaovicmendes joaovicmendes is a code owner

@azevedoalice azevedoalice Awaiting requested review from azevedoalice azevedoalice is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

translation/pt-BR translation waiting for author Waiting on the issue author to reply

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /