Skip to content

Commit a292780

rawen17ldez

authored and

committed

add nakedefer linter - fix bugs

1 parent 7c7b90b commit a292780Copy full SHA for a292780

File tree

3 files changed

+6

-6

lines changed

go.mod
test/testdata
- configs
  - nakedefer.yml
- nakedefer.go

3 files changed

+6

-6

lines changed

`‎go.mod‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@ require (`
`10`	`10`	`github.com/BurntSushi/toml v1.2.1`
`11`	`11`	`github.com/Djarvur/go-err113 v0.0.0-20210108212216-aea10b59be24`
`12`	`12`	`github.com/GaijinEntertainment/go-exhaustruct/v2 v2.3.0`
`13`		`-github.com/GaijinEntertainment/go-nakedefer v1.4.0`
	`13`	`+github.com/GaijinEntertainment/go-nakedefer v1.4.0`
`14`	`14`	`github.com/OpenPeeDeeP/depguard v1.1.1`
`15`	`15`	`github.com/alexkohler/prealloc v1.0.0`
`16`	`16`	`github.com/alingse/asasalint v0.0.11`

`‎test/testdata/configs/nakedefer.yml‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,3 @@`
`1`	`1`	`linters-settings:`
`2`	`2`	`nakedefer:`
`3`		`- exclude: os\.(Create\|WriteFile\|Chmod),fmt\.Print.*,io\.Close`
	`3`	`+ exclude: os\.(Create\|WriteFile\|Chmod),fmt\.Print.*,io\.Close,ignoreFunc`

`‎test/testdata/nakedefer.go‎`

Lines changed: 4 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -32,11 +32,11 @@ func ignoreFunc() error {`
`32`	`32`	`func testCaseValid1() {`
`33`	`33`	`defer funcNotReturnAnyType() // ignore`
`34`	`34`
`35`		`- defer func() { //ignore`
	`35`	`+ defer func() { //ignore`
`36`	`36`	`funcNotReturnAnyType()`
`37`	`37`	`}()`
`38`	`38`
`39`		`- defer func() { //ignore`
	`39`	`+ defer func() { //ignore`
`40`	`40`	`_ = funcReturnErr()`
`41`	`41`	`}()`
`42`	`42`	`}`
`@@ -65,8 +65,8 @@ func testCase1() {`
`65`	`65`	`w.WriteHeader(http.StatusOK)`
`66`	`66`	`_, _ = w.Write([]byte("DONE"))`
`67`	`67`	`}))`
`68`		`- defer srv.Close() //ignore`
`69`		`- defer srv.CloseClientConnections() //ignore`
	`68`	`+ defer srv.Close() //ignore`
	`69`	`+ defer srv.CloseClientConnections() //ignore`
`70`	`70`	`defer srv.Certificate() // want "deferred call should not return anything"`
`71`	`71`	`}`
`72`	`72`

0 commit comments

Comments

(0)