Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: Add required size_check for GH Actions #18009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JPeer264 merged 1 commit into develop from jp/require-size-check
Oct 23, 2025
Merged

Conversation

@JPeer264
Copy link
Member

@JPeer264 JPeer264 commented Oct 23, 2025

It seems that the size limit was not enforced and a PR could be merged without the job being green, see:

Screenshot 2025年10月23日 at 10 12 20

seer-by-sentry[bot] reacted with hooray emoji
Copy link
Contributor

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

Scenario Requests/s % of Baseline Prev. Requests/s Change %
GET Baseline 9,520 - 9,475 +0%
GET With Sentry 1,428 15% 1,349 +6%
GET With Sentry (error only) 6,241 66% 6,020 +4%
POST Baseline 1,215 - 1,189 +2%
POST With Sentry 531 44% 513 +4%
POST With Sentry (error only) 1,072 88% 1,072 -
MYSQL Baseline 3,340 - 3,320 +1%
MYSQL With Sentry 461 14% 431 +7%
MYSQL With Sentry (error only) 2,708 81% 2,688 +1%

View base workflow run

@JPeer264 JPeer264 merged commit 1513161 into develop Oct 23, 2025
107 of 109 checks passed
@JPeer264 JPeer264 deleted the jp/require-size-check branch October 23, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andreiborza andreiborza andreiborza approved these changes

@s1gr1d s1gr1d Awaiting requested review from s1gr1d

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /