Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat(node): Pass requestHook and responseHook option to OTel #17996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JPeer264 merged 2 commits into develop from jp/node-fetch-option
Oct 23, 2025

Conversation

@JPeer264
Copy link
Member

@JPeer264 JPeer264 commented Oct 22, 2025

This adds two new options into the nativeNodeFetchIntegration - the only thing it does is passing the two new options directly into the OTel instrumentation. Since this is OTel related, this is only accessible within the node SDK.

The documentation will be then updated for the fetch integration (it seems that also the spans are missing)

(closes #17953)

seer-by-sentry[bot] reacted with hooray emoji
Copy link
Contributor

github-actions bot commented Oct 22, 2025
edited
Loading

size-limit report 📦

Path Size % Change Change
@sentry/browser 24.63 kB - -
@sentry/browser - with treeshaking flags 23.11 kB - -
@sentry/browser (incl. Tracing) 40.97 kB - -
@sentry/browser (incl. Tracing, Profiling) 45.26 kB - -
@sentry/browser (incl. Tracing, Replay) 79.29 kB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 68.97 kB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 83.99 kB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 96.16 kB - -
@sentry/browser (incl. Feedback) 41.3 kB - -
@sentry/browser (incl. sendFeedback) 29.29 kB - -
@sentry/browser (incl. FeedbackAsync) 34.22 kB - -
@sentry/react 26.31 kB - -
@sentry/react (incl. Tracing) 42.97 kB - -
@sentry/vue 29.11 kB - -
@sentry/vue (incl. Tracing) 42.75 kB - -
@sentry/svelte 24.64 kB - -
CDN Bundle 26.9 kB - -
CDN Bundle (incl. Tracing) 41.62 kB - -
CDN Bundle (incl. Tracing, Replay) 77.87 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 83.35 kB - -
CDN Bundle - uncompressed 78.86 kB - -
CDN Bundle (incl. Tracing) - uncompressed 123.44 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 238.48 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 251.24 kB - -
@sentry/nextjs (client) 45.11 kB - -
@sentry/sveltekit (client) 41.4 kB - -
@sentry/node-core 50.75 kB - -
@sentry/node 156.93 kB +0.01% +12 B 🔺
@sentry/node - without tracing 92.63 kB +0.02% +14 B 🔺
@sentry/aws-serverless 106.35 kB +0.02% +15 B 🔺

View base workflow run

Copy link
Contributor

github-actions bot commented Oct 22, 2025
edited
Loading

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

Scenario Requests/s % of Baseline Prev. Requests/s Change %
GET Baseline 8,506 - 8,670 -2%
GET With Sentry 1,365 16% 1,343 +2%
GET With Sentry (error only) 5,977 70% 6,020 -1%
POST Baseline 1,199 - 1,173 +2%
POST With Sentry 514 43% 499 +3%
POST With Sentry (error only) 1,050 88% 1,047 +0%
MYSQL Baseline 3,295 - 3,280 +0%
MYSQL With Sentry 466 14% 425 +10%
MYSQL With Sentry (error only) 2,705 82% 2,670 +1%

View base workflow run

Copy link
Member

@s1gr1d s1gr1d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice,

@s1gr1d s1gr1d changed the title (削除) feat(node): pass requestHook and responseHook option to OTel (削除ここまで) (追記) feat(node): Pass requestHook and responseHook option to OTel (追記ここまで) Oct 22, 2025
@JPeer264 JPeer264 merged commit f75c3ed into develop Oct 23, 2025
132 of 134 checks passed
@JPeer264 JPeer264 deleted the jp/node-fetch-option branch October 23, 2025 08:30
JPeer264 added a commit to getsentry/sentry-docs that referenced this pull request Oct 24, 2025
<!-- Use this checklist to make sure your PR is ready for merge. You may
delete any sections you don't need. -->
## DESCRIBE YOUR PR
This is the documentation for
getsentry/sentry-javascript#17996 (it also adds
the missing `spans`).
Now I think I did a little hack, since these options are not available
in `node-core`, but `javascript.node-core` is not a identifier. So I
show a little warning for only `javascript.node` that it is not
available in the `node-core` package. Since all other integrations use
`@sentry/node` anyways, we don't have to show this warning so that is
why I use the `<PlatformSection />` as well.
## IS YOUR CHANGE URGENT? 
Help us prioritize incoming PRs by letting us know when the change needs
to go live.
- [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE -->
- [ ] Other deadline: <!-- ENTER DATE HERE -->
- [x] None: Not urgent, can wait up to 1 week+
## SLA
- Teamwork makes the dream work, so please add a reviewer to your PRs.
- Please give the docs team up to 1 week to review your PR unless you've
added an urgent due date to it.
Thanks in advance for your help!
## PRE-MERGE CHECKLIST
*Make sure you've checked the following before merging your changes:*
- [ ] Checked Vercel preview for correctness, including links
- [ ] PR was reviewed and approved by any necessary SMEs (subject matter
experts)
- [ ] PR was reviewed and approved by a member of the [Sentry docs
team](https://github.com/orgs/getsentry/teams/docs)
## EXTRA RESOURCES
- [Sentry Docs contributor guide](https://docs.sentry.io/contributing/)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@s1gr1d s1gr1d s1gr1d approved these changes

@chargome chargome Awaiting requested review from chargome

@RulaKhaled RulaKhaled Awaiting requested review from RulaKhaled

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Align capabilities of nativeNodeFetchIntegration with httpIntegration

AltStyle によって変換されたページ (->オリジナル) /