-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
-
I was testing how the feedback dialog for ErrorBoundary works in a nextjs app. I used the showDialog prop. On a list of 14 items, I was throwing an error for each item (simulating by calling a non existent function).
To my surprise ErrorBoundary showed the feedback dialog 14 times... I had to click close 14 times in the feedback dialog to get rid of them all.
Is this the expected behavior?
Beta Was this translation helpful? Give feedback.
All reactions
Replies: 1 comment 1 reply
-
Since we are just calling componentDidCatch here, it seems that componentDidCatch is being called 14 times then.
Perhaps there should be a way for us to dedupe this - transferring as an issue so we can backlog and investigate further, but PRs welcome!
Beta Was this translation helpful? Give feedback.
All reactions
-
Issue here: #5646
Beta Was this translation helpful? Give feedback.