Commit e966cdc

authored

doc(core): Fix outdated JSDoc in beforeSendSpan (#17815)

Spotted that we still documented that the root span does not go through `beforeSendSpan`. This is outdated. Since v9, we also pass the root span to the callback.

1 parent 7b40a95 commit e966cdcCopy full SHA for e966cdc

File tree

1 file changed

-3

lines changed

packages/core/src/types-hoist
- options.ts

1 file changed

-3

lines changed

`‎packages/core/src/types-hoist/options.ts‎`

Lines changed: 0 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -408,9 +408,6 @@ export interface ClientOptions<TO extends BaseTransportOptions = BaseTransportOp`
`408`	`408`	`/**`
`409`	`409`	`* This function can be defined to modify a child span before it's sent.`
`410`	`410`	`*`
`411`		`- * Note that this function is only called for child spans and not for the root span (formerly known as transaction).`
`412`		`- * If you want to modify or drop the root span, use {@link CoreOptions.beforeSendTransaction} instead.`
`413`		`- *`
`414`	`411`	`* @param span The span generated by the SDK.`
`415`	`412`	`*`
`416`	`413`	`* @returns The modified span payload that will be sent.`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit e966cdc

File tree

1 file changed

1 file changed

`‎packages/core/src/types-hoist/options.ts‎`

0 commit comments