Commit dcd9c05

committed

rebase and fix some tests

1 parent d6d262e commit dcd9c05Copy full SHA for dcd9c05

File tree

-4

lines changed

dev-packages/browser-integration-tests/suites/integrations/supabase/auth
- test.ts
packages/opentelemetry
- src/utils
  - mapStatus.ts
- test/utils
  - mapStatus.test.ts

-4

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -143,7 +143,7 @@ sentryTest('should capture Supabase authentication errors', async ({ getLocalTes`
`143`	`143`	`start_timestamp: expect.any(Number),`
`144`	`144`	`timestamp: expect.any(Number),`
`145`	`145`	`trace_id: transactionEvent.contexts?.trace?.trace_id,`
`146`		`- status: 'unknown_error',`
	`146`	`+ status: 'internal_error',`
`147`	`147`	`data: expect.objectContaining({`
`148`	`148`	`'sentry.op': 'db',`
`149`	`149`	`'sentry.origin': 'auto.db.supabase',`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -56,7 +56,7 @@ export function mapStatus(span: AbstractSpan): SpanStatus {`
`56`	`56`	`if (status.message && isStatusErrorMessageValid(status.message)) {`
`57`	`57`	`return { code: SPAN_STATUS_ERROR, message: status.message };`
`58`	`58`	`} else {`
`59`		`- return { code: SPAN_STATUS_ERROR, message: 'unknown_error' };`
	`59`	`+ return { code: SPAN_STATUS_ERROR, message: 'internal_error' };`
`60`	`60`	`}`
`61`	`61`	`}`
`62`	`62`	`}`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ describe('mapStatus', () => {`
`40`	`40`	`[501, undefined, { code: SPAN_STATUS_ERROR, message: 'unimplemented' }],`
`41`	`41`	`[503, undefined, { code: SPAN_STATUS_ERROR, message: 'unavailable' }],`
`42`	`42`	`[504, undefined, { code: SPAN_STATUS_ERROR, message: 'deadline_exceeded' }],`
`43`		`- [999, undefined, { code: SPAN_STATUS_ERROR, message: 'unknown_error' }],`
	`43`	`+ [999, undefined, { code: SPAN_STATUS_ERROR, message: 'internal_error' }],`
`44`	`44`
`45`	`45`	`// grpc codes`
`46`	`46`	`[undefined, '1', { code: SPAN_STATUS_ERROR, message: 'cancelled' }],`
`@@ -112,7 +112,7 @@ describe('mapStatus', () => {`
`112`	`112`	`it('returns error status when span already has error status without message', () => {`
`113`	`113`	`const span = createSpan('test-span');`
`114`	`114`	`span.setStatus({ code: 2 }); // ERROR`
`115`		`- expect(mapStatus(span)).toEqual({ code: SPAN_STATUS_ERROR, message: 'unknown_error' });`
	`115`	`+ expect(mapStatus(span)).toEqual({ code: SPAN_STATUS_ERROR, message: 'internal_error' });`
`116`	`116`	`});`
`117`	`117`
`118`	`118`	`it('infers error status form attributes when span already has error status without message', () => {`

Comments

(0)