Commit c587947

authored

ref(astro): Adjust mechanism on error events captured by astro middleware (#17613)

mechanism type now follows the trace origin naming scheme closes #17612

1 parent e1c4367 commit c587947Copy full SHA for c587947

File tree

-22

lines changed

dev-packages/e2e-tests/test-applications
- astro-4/tests
  - errors.server.test.ts
- astro-5/tests
  - errors.server.test.ts
packages/astro
- src/server
  - middleware.ts
- test/server
  - middleware.test.ts

-22

lines changed

Lines changed: 2 additions & 8 deletions

Original file line number	Diff line number	Diff line change
`@@ -47,11 +47,8 @@ test.describe('server-side errors', () => {`
`47`	`47`	`values: [`
`48`	`48`	`{`
`49`	`49`	`mechanism: {`
`50`		`- data: {`
`51`		`- function: 'astroMiddleware',`
`52`		`- },`
`53`	`50`	`handled: false,`
`54`		`- type: 'astro',`
	`51`	`+ type: 'auto.middleware.astro',`
`55`	`52`	`},`
`56`	`53`	`stacktrace: expect.any(Object),`
`57`	`54`	`type: 'TypeError',`
`@@ -136,11 +133,8 @@ test.describe('server-side errors', () => {`
`136`	`133`	`values: [`
`137`	`134`	`{`
`138`	`135`	`mechanism: {`
`139`		`- data: {`
`140`		`- function: 'astroMiddleware',`
`141`		`- },`
`142`	`136`	`handled: false,`
`143`		`- type: 'astro',`
	`137`	`+ type: 'auto.middleware.astro',`
`144`	`138`	`},`
`145`	`139`	`stacktrace: expect.any(Object),`
`146`	`140`	`type: 'Error',`

Lines changed: 2 additions & 8 deletions

Original file line number	Diff line number	Diff line change
`@@ -47,11 +47,8 @@ test.describe('server-side errors', () => {`
`47`	`47`	`values: [`
`48`	`48`	`{`
`49`	`49`	`mechanism: {`
`50`		`- data: {`
`51`		`- function: 'astroMiddleware',`
`52`		`- },`
`53`	`50`	`handled: false,`
`54`		`- type: 'astro',`
	`51`	`+ type: 'auto.middleware.astro',`
`55`	`52`	`},`
`56`	`53`	`stacktrace: expect.any(Object),`
`57`	`54`	`type: 'TypeError',`
`@@ -136,11 +133,8 @@ test.describe('server-side errors', () => {`
`136`	`133`	`values: [`
`137`	`134`	`{`
`138`	`135`	`mechanism: {`
`139`		`- data: {`
`140`		`- function: 'astroMiddleware',`
`141`		`- },`
`142`	`136`	`handled: false,`
`143`		`- type: 'astro',`
	`137`	`+ type: 'auto.middleware.astro',`
`144`	`138`	`},`
`145`	`139`	`stacktrace: expect.any(Object),`
`146`	`140`	`type: 'Error',`

Lines changed: 1 addition & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -50,11 +50,8 @@ function sendErrorToSentry(e: unknown): unknown {`
`50`	`50`
`51`	`51`	`captureException(objectifiedErr, {`
`52`	`52`	`mechanism: {`
`53`		`- type: 'astro',`
	`53`	`+ type: 'auto.middleware.astro',`
`54`	`54`	`handled: false,`
`55`		`- data: {`
`56`		`- function: 'astroMiddleware',`
`57`		`- },`
`58`	`55`	`},`
`59`	`56`	`});`
`60`	`57`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -168,7 +168,7 @@ describe('sentryMiddleware', () => {`
`168`	`168`	`await expect(async () => middleware(ctx, next)).rejects.toThrowError();`
`169`	`169`
`170`	`170`	`expect(captureExceptionSpy).toHaveBeenCalledWith(error, {`
`171`		`- mechanism: { handled: false, type: 'astro',data: {function: 'astroMiddleware'} },`
	`171`	`+ mechanism: { handled: false, type: 'auto.middleware.astro' },`
`172`	`172`	`});`
`173`	`173`	`});`
`174`	`174`
`@@ -205,7 +205,7 @@ describe('sentryMiddleware', () => {`
`205`	`205`	`await expect(() => resultFromNext!.text()).rejects.toThrowError();`
`206`	`206`
`207`	`207`	`expect(captureExceptionSpy).toHaveBeenCalledWith(error, {`
`208`		`- mechanism: { handled: false, type: 'astro',data: {function: 'astroMiddleware'} },`
	`208`	`+ mechanism: { handled: false, type: 'auto.middleware.astro' },`
`209`	`209`	`});`
`210`	`210`	`});`
`211`	`211`

Comments

(0)