Skip to content

Commit 702cc87

authored

ref(solidstart): Adjust event mechanism in withServerActionInstrumentation (#17637)

mechanism type now follows the trace origin naming scheme closes #17638

1 parent 1834094 commit 702cc87Copy full SHA for 702cc87

File tree

7 files changed

+9

-6

lines changed

CHANGELOG.md
dev-packages/e2e-tests/test-applications
- solidstart-dynamic-import/tests
  - errors.server.test.ts
- solidstart-spa/tests
  - errors.server.test.ts
- solidstart-top-level-import/tests
  - errors.server.test.ts
- solidstart/tests
  - errors.server.test.ts
packages/solidstart
- src/server
  - withServerActionInstrumentation.ts
- test/server
  - withServerActionInstrumentation.test.ts

7 files changed

+9

-6

lines changed

`‎CHANGELOG.md‎`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -34,6 +34,7 @@`
`34`	`34`	- ref(remix): Adjust event mechanism of `captureRemixServerException` ([#17629](https://github.com/getsentry/sentry-javascript/pull/17629))
`35`	`35`	- ref(replay-internal): Add mechanism to error caught by `replayIntegration` in debug mode ([#17606](https://github.com/getsentry/sentry-javascript/pull/17606))
`36`	`36`	- ref(solid): Add `mechanism` to error captured by `withSentryErrorBoundary` ([#17607](https://github.com/getsentry/sentry-javascript/pull/17607))
	`37`	`+ - ref(solidstart): Adjust event mechanism in withServerActionInstrumentation ([#17637](https://github.com/getsentry/sentry-javascript/pull/17637))`
`37`	`38`	- ref(sveltekit): Adjust `mechanism` of error events ([#17646](https://github.com/getsentry/sentry-javascript/pull/17646))
`38`	`39`	`- ref(vue): Adjust mechanism in Vue error handler ([#17647](https://github.com/getsentry/sentry-javascript/pull/17647))`
`39`	`40`

`‎dev-packages/e2e-tests/test-applications/solidstart-dynamic-import/tests/errors.server.test.ts‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@ test.describe('server-side errors', () => {`
`18`	`18`	`type: 'Error',`
`19`	`19`	`value: 'Error thrown from Solid Start E2E test app server route',`
`20`	`20`	`mechanism: {`
`21`		`- type: 'solidstart',`
	`21`	`+ type: 'auto.function.solidstart',`
`22`	`22`	`handled: false,`
`23`	`23`	`},`
`24`	`24`	`},`

`‎dev-packages/e2e-tests/test-applications/solidstart-spa/tests/errors.server.test.ts‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@ test.describe('server-side errors', () => {`
`18`	`18`	`type: 'Error',`
`19`	`19`	`value: 'Error thrown from Solid Start E2E test app server route',`
`20`	`20`	`mechanism: {`
`21`		`- type: 'solidstart',`
	`21`	`+ type: 'auto.function.solidstart',`
`22`	`22`	`handled: false,`
`23`	`23`	`},`
`24`	`24`	`},`

`‎dev-packages/e2e-tests/test-applications/solidstart-top-level-import/tests/errors.server.test.ts‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@ test.describe('server-side errors', () => {`
`18`	`18`	`type: 'Error',`
`19`	`19`	`value: 'Error thrown from Solid Start E2E test app server route',`
`20`	`20`	`mechanism: {`
`21`		`- type: 'solidstart',`
	`21`	`+ type: 'auto.function.solidstart',`
`22`	`22`	`handled: false,`
`23`	`23`	`},`
`24`	`24`	`},`

`‎dev-packages/e2e-tests/test-applications/solidstart/tests/errors.server.test.ts‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@ test.describe('server-side errors', () => {`
`18`	`18`	`type: 'Error',`
`19`	`19`	`value: 'Error thrown from Solid Start E2E test app server route',`
`20`	`20`	`mechanism: {`
`21`		`- type: 'solidstart',`
	`21`	`+ type: 'auto.function.solidstart',`
`22`	`22`	`handled: false,`
`23`	`23`	`},`
`24`	`24`	`},`

`‎packages/solidstart/src/server/withServerActionInstrumentation.ts‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,7 @@ export async function withServerActionInstrumentation<A extends (...args: unknow`
`48`	`48`	`captureException(error, {`
`49`	`49`	`mechanism: {`
`50`	`50`	`handled: false,`
`51`		`- type: 'solidstart',`
	`51`	`+ type: 'auto.function.solidstart',`
`52`	`52`	`},`
`53`	`53`	`});`
`54`	`54`	`}`

`‎packages/solidstart/test/server/withServerActionInstrumentation.test.ts‎`

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -74,7 +74,9 @@ describe('withServerActionInstrumentation', () => {`
`74`	`74`	`await expect(res).rejects.toThrow();`
`75`	`75`
`76`	`76`	`expect(mockCaptureException).toHaveBeenCalledTimes(1);`
`77`		`- expect(mockCaptureException).toHaveBeenCalledWith(error, { mechanism: { handled: false, type: 'solidstart' } });`
	`77`	`+ expect(mockCaptureException).toHaveBeenCalledWith(error, {`
	`78`	`+ mechanism: { handled: false, type: 'auto.function.solidstart' },`
	`79`	`+ });`
`78`	`80`	`});`
`79`	`81`
`80`	`82`	`it("doesn't call captureException for thrown redirects", async () => {`

0 commit comments

Comments

(0)