Commit 14888ab

authored

fix(tracemetrics): Bump metrics buffer to 1k (#18039)

1 parent fe97d67 commit 14888abCopy full SHA for 14888ab

File tree

-4

lines changed

packages/core
- src/metrics
  - internal.ts
- test/lib/metrics
  - internal.test.ts

-4

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,7 @@ import { timestampInSeconds } from '../utils/time';`
`12`	`12`	`import { _getTraceInfoFromScope } from '../utils/trace-info';`
`13`	`13`	`import { createMetricEnvelope } from './envelope';`
`14`	`14`
`15`		`-const MAX_METRIC_BUFFER_SIZE = 100;`
	`15`	`+const MAX_METRIC_BUFFER_SIZE = 1000;`
`16`	`16`
`17`	`17`	`/**`
`18`	`18`	`* Converts a metric attribute to a serialized metric attribute.`

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -249,12 +249,12 @@ describe('_INTERNAL_captureMetric', () => {`
`249`	`249`	`const scope = new Scope();`
`250`	`250`	`scope.setClient(client);`
`251`	`251`
`252`		`- // Fill the buffer to max size (100 is the MAX_METRIC_BUFFER_SIZE constant)`
`253`		`- for (let i = 0; i < 100; i++) {`
	`252`	`+ // Fill the buffer to max size (1000 is the MAX_METRIC_BUFFER_SIZE constant)`
	`253`	`+ for (let i = 0; i < 1000; i++) {`
`254`	`254`	_INTERNAL_captureMetric({ type: 'counter', name: `metric.${i}`, value: i }, { scope });
`255`	`255`	`}`
`256`	`256`
`257`		`- expect(_INTERNAL_getMetricBuffer(client)).toHaveLength(100);`
	`257`	`+ expect(_INTERNAL_getMetricBuffer(client)).toHaveLength(1000);`
`258`	`258`
`259`	`259`	`// Add one more to trigger flush`
`260`	`260`	`_INTERNAL_captureMetric({ type: 'counter', name: 'trigger.flush', value: 999 }, { scope });`

Comments

(0)