Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commit ba2b6f7

Browse files
committed
Rename constants
1 parent a6f503a commit ba2b6f7

File tree

1 file changed

+13
-14
lines changed

1 file changed

+13
-14
lines changed

‎src/blame_all.py‎

Lines changed: 13 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,9 @@
44
from .base import BaseBlame
55
from .templates import blame_all_phantom_css, blame_all_phantom_html_template
66

7-
VIEW_SETTING_PHANTOM_ALL_DISPLAYED = "git-blame-all-displayed"
8-
9-
VIEW_SETTING_RULERS = "rulers"
10-
VIEW_SETTING_RULERS_PREV = "rulers_prev"
7+
VIEW_SETTINGS_KEY_PHANTOM_ALL_DISPLAYED = "git-blame-all-displayed"
8+
VIEW_SETTINGS_KEY_RULERS = "rulers" # A stock ST setting
9+
VIEW_SETTINGS_KEY_RULERS_PREV = "rulers_prev" # Made up by us
1110

1211

1312
class BlameShowAll(BaseBlame, sublime_plugin.TextCommand):
@@ -30,9 +29,9 @@ def run(self, edit):
3029
phantoms = [] # type: list[sublime.Phantom] # type: ignore[misc]
3130

3231
# If they are currently shown, toggle them off and return.
33-
if self.view.settings().get(VIEW_SETTING_PHANTOM_ALL_DISPLAYED, False):
32+
if self.view.settings().get(VIEW_SETTINGS_KEY_PHANTOM_ALL_DISPLAYED, False):
3433
self.phantom_set.update(phantoms)
35-
self.view.settings().erase(VIEW_SETTING_PHANTOM_ALL_DISPLAYED)
34+
self.view.settings().erase(VIEW_SETTINGS_KEY_PHANTOM_ALL_DISPLAYED)
3635
self.view.run_command("blame_restore_rulers")
3736
# Workaround a visible empty space sometimes remaining in the viewport.
3837
self.horizontal_scroll_to_limit(left=False)
@@ -75,7 +74,7 @@ def run(self, edit):
7574
phantoms.append(phantom)
7675

7776
self.phantom_set.update(phantoms)
78-
self.view.settings().set(VIEW_SETTING_PHANTOM_ALL_DISPLAYED, True)
77+
self.view.settings().set(VIEW_SETTINGS_KEY_PHANTOM_ALL_DISPLAYED, True)
7978
self.store_rulers()
8079
# Bring the phantoms into view without the user needing to manually scroll left.
8180
self.horizontal_scroll_to_limit(left=True)
@@ -102,10 +101,10 @@ def phantom_region(self, line_number):
102101

103102
def store_rulers(self):
104103
self.view.settings().set(
105-
VIEW_SETTING_RULERS_PREV,
106-
self.view.settings().get(VIEW_SETTING_RULERS),
104+
VIEW_SETTINGS_KEY_RULERS_PREV,
105+
self.view.settings().get(VIEW_SETTINGS_KEY_RULERS),
107106
)
108-
self.view.settings().set(VIEW_SETTING_RULERS, [])
107+
self.view.settings().set(VIEW_SETTINGS_KEY_RULERS, [])
109108

110109
def horizontal_scroll_to_limit(self, *, left):
111110
x = 0.0 if left else self.view.layout_extent()[0]
@@ -124,7 +123,7 @@ class BlameEraseAll(sublime_plugin.TextCommand):
124123
def run(self, edit):
125124
sublime.status_message("The git blame result is cleared.")
126125
self.view.erase_phantoms(BlameShowAll.phantom_set_key())
127-
self.view.settings().erase(VIEW_SETTING_PHANTOM_ALL_DISPLAYED)
126+
self.view.settings().erase(VIEW_SETTINGS_KEY_PHANTOM_ALL_DISPLAYED)
128127
self.view.run_command("blame_restore_rulers")
129128

130129
# Overrides end --------------------------------------------------------------------
@@ -136,7 +135,7 @@ class BlameEraseAllListener(sublime_plugin.ViewEventListener):
136135

137136
@classmethod
138137
def is_applicable(cls, settings):
139-
return settings.get(VIEW_SETTING_PHANTOM_ALL_DISPLAYED, False)
138+
return settings.get(VIEW_SETTINGS_KEY_PHANTOM_ALL_DISPLAYED, False)
140139

141140
def on_modified_async(self):
142141
self.view.run_command("blame_erase_all")
@@ -150,8 +149,8 @@ class BlameRestoreRulers(sublime_plugin.TextCommand):
150149

151150
def run(self, edit):
152151
self.view.settings().set(
153-
VIEW_SETTING_RULERS,
154-
self.view.settings().get(VIEW_SETTING_RULERS_PREV),
152+
VIEW_SETTINGS_KEY_RULERS,
153+
self.view.settings().get(VIEW_SETTINGS_KEY_RULERS_PREV),
155154
)
156155

157156
# Overrides end --------------------------------------------------------------------

0 commit comments

Comments
(0)

AltStyle によって変換されたページ (->オリジナル) /