-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
feature(vue): support v-model binding on smart-select #4307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
This merge request adds a
v-model:smart-selectionmodel binding for the smart list element when used on anf7-list-item. Example syntax (as per the kitchen sink update) is something like:The key driver for this change is I wanted a more ergonomic way to programmatically control which item is selected in a smart-select component.
I don't particularly love the model name of
smart-selection. Alternatives I considered:valueprop to be a model (i.e., add aupdate:valueemit)selectionor eventselectinstead, but I felt this dropped the clear link to the smart-select component?This is a completely random drive-by feature, so I'm absolutely fine with it being closed if it's not something you want. If you like the concept but want changes made, I'd be thrilled to adjust the patch to your liking 🙂
Also, I'd be happy to update the docs as well if this feature is accepted.
Thanks for all your hard work on the framework!