Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feature(vue): support v-model binding on smart-select #4307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
peitschie wants to merge 1 commit into framework7io:master
base: master
Choose a base branch
Loading
from peitschie:vue-smart-select

Conversation

@peitschie
Copy link
Contributor

@peitschie peitschie commented Feb 2, 2025
edited
Loading

This merge request adds a v-model:smart-selection model binding for the smart list element when used on an f7-list-item. Example syntax (as per the kitchen sink update) is something like:

 <f7-list-item
 v-model:smart-selection="predictedCoinFlip"
 title="Predicted outcome"
 smart-select
 :smart-select-params="{ openIn: 'sheet' }"
>
 <select name="coin-flip">
 <option value="heads">Heads</option>
 <option value="tails">Tails</option>
 </select>
</f7-list-item>

The key driver for this change is I wanted a more ergonomic way to programmatically control which item is selected in a smart-select component.

I don't particularly love the model name of smart-selection. Alternatives I considered:

  1. extend the existing value prop to be a model (i.e., add a update:value emit)
  2. call it selection or event select instead, but I felt this dropped the clear link to the smart-select component?

This is a completely random drive-by feature, so I'm absolutely fine with it being closed if it's not something you want. If you like the concept but want changes made, I'd be thrilled to adjust the patch to your liking 🙂

Also, I'd be happy to update the docs as well if this feature is accepted.

Thanks for all your hard work on the framework!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

AltStyle によって変換されたページ (->オリジナル) /