Use parse instead of format when calculating checked #974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

jharding wants to merge 1 commit into final-form:main

from jharding:bug/fix-parse-format-radio-checkbox

Open

Use parse instead of format when calculating checked #974

jharding wants to merge 1 commit into final-form:main from jharding:bug/fix-parse-format-radio-checkbox

Conversation

@jharding

Copy link

@jharding jharding commented Feb 14, 2022

This may be an incorrect assumption, but it seems like the getter for checked should be using parse, not format when comparing values. In addition to fixing an issue I was experiencing, the TypeScript definitions suggest this should be the intended behavior as well as parse returns FieldValue and state.config is of the type FieldValue.

I added a couple of tests to prevent future regressions – please let me know if there's anything else I should do to get this to a state where you'd be comfortable accepting the patch.

Thanks for the great library!

@jharding


 Use parse instead of format when calculating checked

@codesandbox-ci

Copy link

codesandbox-ci bot commented Feb 14, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9839445:

Sandbox	Source
React Final Form - Simple Example	Configuration
React Final Form - Synchronous Record Level Validation	Configuration
React Final Form - Synchronous Field Level Validation	Configuration
final-form/react-final-form	Configuration
React Final Form - Subscriptions Example	Configuration