Commit df0d0dc

committed

fix memory leak - remove event listener

1 parent 6eccb6b commit df0d0dcCopy full SHA for df0d0dc

File tree

+19

-6

lines changed

+19

-6

lines changed

Lines changed: 19 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,6 @@`
`1`	`1`	`/* global Blob, FileReader */`
`2`	`2`
	`3`	`+// arraybuffer -> buffer without copy`
`3`	`4`	`var toBuffer = require('typedarray-to-buffer')`
`4`	`5`
`5`	`6`	`module.exports = function blobToBuffer (blob, cb) {`
`@@ -11,11 +12,23 @@ module.exports = function blobToBuffer (blob, cb) {`
`11`	`12`	`}`
`12`	`13`
`13`	`14`	`var reader = new FileReader()`
`14`		`- reader.addEventListener('load', function (e) {`
`15`		`- // uint8array -> buffer without copy`
`16`		`- var buffer = toBuffer(new Uint8Array(e.target.result))`
`17`		`- cb(null, buffer)`
`18`		`- })`
`19`		`- reader.addEventListener('error', cb)`
	`15`	`+`
	`16`	`+ function onLoad (e) {`
	`17`	`+ unregisterEvents()`
	`18`	`+ cb(null, toBuffer(e.target.result))`
	`19`	`+ }`
	`20`	`+`
	`21`	`+ function onError (err) {`
	`22`	`+ unregisterEvents()`
	`23`	`+ cb(err)`
	`24`	`+ }`
	`25`	`+`
	`26`	`+ function unregisterEvents () {`
	`27`	`+ reader.removeEventListener('load', onLoad)`
	`28`	`+ reader.removeEventListener('error', onError)`
	`29`	`+ }`
	`30`	`+`
	`31`	`+ reader.addEventListener('load', onLoad)`
	`32`	`+ reader.addEventListener('error', onError)`
`20`	`33`	`reader.readAsArrayBuffer(blob)`
`21`	`34`	`}`

Comments

(0)