Commit 83a4f69

authored

Merge pull request #333 from toughengineer/made_function_non-template

Made function non-template

2 parents 7262d94 + 1ea4d25 commit 83a4f69Copy full SHA for 83a4f69

File tree

1 file changed

-7

lines changed

include/fast_float
- digit_comparison.h

1 file changed

-7

lines changed

`‎include/fast_float/digit_comparison.h‎`

Lines changed: 5 additions & 7 deletions

Original file line number	Diff line number	Diff line change
`@@ -38,11 +38,8 @@ constexpr static uint64_t powers_of_ten_uint64[] = {1UL,`
`38`	`38`	`// this algorithm is not even close to optimized, but it has no practical`
`39`	`39`	`// effect on performance: in order to have a faster algorithm, we'd need`
`40`	`40`	`// to slow down performance for faster algorithms, and this is still fast.`
`41`		`-template <typename UC>`
`42`	`41`	`fastfloat_really_inline FASTFLOAT_CONSTEXPR14 int32_t`
`43`		`-scientific_exponent(parsed_number_string_t<UC> &num) noexcept {`
`44`		`- uint64_t mantissa = num.mantissa;`
`45`		`- int32_t exponent = int32_t(num.exponent);`
	`42`	`+scientific_exponent(uint64_t mantissa, int32_t exponent) noexcept {`
`46`	`43`	`while (mantissa >= 10000) {`
`47`	`44`	`mantissa /= 10000;`
`48`	`45`	`exponent += 4;`
`@@ -398,7 +395,7 @@ inline FASTFLOAT_CONSTEXPR20 adjusted_mantissa negative_digit_comp(`
`398`	`395`	`FASTFLOAT_ASSERT(real_digits.pow2(uint32_t(-pow2_exp)));`
`399`	`396`	`}`
`400`	`397`
`401`		`- // compare digits, and use it to director rounding`
	`398`	`+ // compare digits, and use it to direct rounding`
`402`	`399`	`int ord = real_digits.compare(theor_digits);`
`403`	`400`	`adjusted_mantissa answer = am;`
`404`	`401`	`round<T>(answer, [ord](adjusted_mantissa &a, int32_t shift) {`
`@@ -419,7 +416,7 @@ inline FASTFLOAT_CONSTEXPR20 adjusted_mantissa negative_digit_comp(`
`419`	`416`	`return answer;`
`420`	`417`	`}`
`421`	`418`
`422`		`-// parse the significant digits as a big integer to unambiguously round the`
	`419`	`+// parse the significant digits as a big integer to unambiguously round`
`423`	`420`	`// the significant digits. here, we are trying to determine how to round`
`424`	`421`	// an extended float representation close to `b+h`, halfway between `b`
`425`	`422`	// (the float rounded-down) and `b+u`, the next positive float. this
`@@ -438,7 +435,8 @@ digit_comp(parsed_number_string_t<UC> &num, adjusted_mantissa am) noexcept {`
`438`	`435`	`// remove the invalid exponent bias`
`439`	`436`	`am.power2 -= invalid_am_bias;`
`440`	`437`
`441`		`- int32_t sci_exp = scientific_exponent(num);`
	`438`	`+ int32_t sci_exp =`
	`439`	`+ scientific_exponent(num.mantissa, static_cast<int32_t>(num.exponent));`
`442`	`440`	`size_t max_digits = binary_format<T>::max_digits();`
`443`	`441`	`size_t digits = 0;`
`444`	`442`	`bigint bigmant;`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit 83a4f69

File tree

1 file changed

1 file changed

`‎include/fast_float/digit_comparison.h‎`

0 commit comments