Commit d8ac0db

jsberlangaJulio Soto

and

Julio Soto

authored

fix: useEffect cleanup function (#122)

Co-authored-by: Julio Soto <julio.soto@schibsted.com>

1 parent 70b23ac commit d8ac0dbCopy full SHA for d8ac0db

File tree

-2

lines changed

-2

lines changed

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,9 @@ function useSafeDispatch(dispatch) {`
`21`	`21`	`// interact with the dom may depend on the value being set`
`22`	`22`	`React.useEffect(() => {`
`23`	`23`	`mountedRef.current = true`
`24`		`- return () => (mountedRef.current = false)`
	`24`	`+ return () => {`
	`25`	`+ mountedRef.current = false`
	`26`	`+ }`
`25`	`27`	`}, [])`
`26`	`28`
`27`	`29`	`return React.useCallback(`

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -5,7 +5,9 @@ function useSafeDispatch(dispatch) {`
`5`	`5`
`6`	`6`	`React.useLayoutEffect(() => {`
`7`	`7`	`mounted.current = true`
`8`		`- return () => (mounted.current = false)`
	`8`	`+ return () => {`
	`9`	`+ mounted.current = false`
	`10`	`+ }`
`9`	`11`	`}, [])`
`10`	`12`
`11`	`13`	`return React.useCallback(`

Comments

(0)