Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commit 7f4a000

Browse files
add deprecation warning to safe-dispatch extra credit (#206)
1 parent 6b0433c commit 7f4a000

File tree

1 file changed

+4
-17
lines changed

1 file changed

+4
-17
lines changed

‎src/exercise/02.md‎

Lines changed: 4 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -328,23 +328,10 @@ React.useEffect(() => {
328328

329329
[Production deploy](https://advanced-react-hooks.netlify.com/isolated/final/02.extra-3.js)
330330

331-
**NOTICE: Things have changed slightly.** The app you're running the exercises
332-
in was changed since the videos were recorded and you can no longer see this
333-
issue by changing the exercise. All the exercises are now rendered in an iframe
334-
on the exercise pages, so when you go to a different exercise, you're
335-
effectively "closing" the page, so all JS execution for that exercise stops.
336-
337-
So I've added a little checkbox which you can use to mount and unmount the
338-
component with ease. This has the benefit of also working on the isolated page
339-
as well. On the exercise page, you'll want to make sure that your console output
340-
is showing the output from the iframe by
341-
[selecting the right context](https://developers.google.com/web/tools/chrome-devtools/console/reference#context).
342-
343-
I've also added a test for this one to help make sure you've got it right.
344-
345-
Also notice that while what we're doing here is still useful and you'll learn
346-
valuable skills, the warning we're suppressing
347-
[goes away in React v18](https://github.com/reactwg/react-18/discussions/82).
331+
**NOTICE: Things have changed.** React 18 has since [deprecated
332+
the warning](https://github.com/facebook/react/pull/22114) highlighted in this
333+
exercise. This extra credit has been left here in-case you are **curious only**. You
334+
**should not** expect to be able to reproduce the scenario as described in the exercise.
348335

349336
Phew, ok, back to your extra credit!
350337

0 commit comments

Comments
(0)

AltStyle によって変換されたページ (->オリジナル) /