Commit 50920d6

committed

#limit and #offset validate value param

1 parent 7bc4c7b commit 50920d6Copy full SHA for 50920d6

File tree

+14

-0

lines changed

elasticsearch-model
- lib/elasticsearch/model/response
  - pagination.rb
- test/unit
  - response_pagination_kaminari_test.rb

+14

-0

lines changed

Lines changed: 2 additions & 0 deletions

Lines changed: 12 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -109,6 +109,12 @@ def self.document_type; 'bar'; end`
`109`	`109`	`@response.limit("35")`
`110`	`110`	`assert_equal 35, @response.search.definition[:size]`
`111`	`111`	`end`
	`112`	`+`
	`113`	`+ should 'ignore invalid string parameters' do`
	`114`	`+ @response.limit(35)`
	`115`	`+ @response.limit("asdf")`
	`116`	`+ assert_equal 35, @response.search.definition[:size]`
	`117`	`+ end`
`112`	`118`	`end`
`113`	`119`
`114`	`120`	`context "with the page() and limit() methods" do`
`@@ -161,6 +167,12 @@ def self.document_type; 'bar'; end`
`161`	`167`	`@response.offset("35")`
`162`	`168`	`assert_equal 35, @response.search.definition[:from]`
`163`	`169`	`end`
	`170`	`+`
	`171`	`+ should 'ignore invalid string parameters' do`
	`172`	`+ @response.offset(35)`
	`173`	`+ @response.offset("asdf")`
	`174`	`+ assert_equal 35, @response.search.definition[:from]`
	`175`	`+ end`
`164`	`176`	`end`
`165`	`177`
`166`	`178`	`context "total" do`

Comments

(0)