Commit 4ee1708

sinisterchipmunkpicandocodigo

authored and

committed

Test that the model namespace isn't polluted.

The goal of ClassMethodsProxy is to avoid polluting the target's namespace, but it was possible to do this by accident when calling `class_eval` before ActiveSupport was completely loaded. This test ensures the namespace isn't polluted, regardless of the load state of ActiveSupport.

1 parent 33aa4bb commit 4ee1708Copy full SHA for 4ee1708

File tree

1 file changed

-0

lines changed

elasticsearch-model/spec/elasticsearch/model/adapters/active_record
- import_spec.rb

1 file changed

-0

lines changed

`‎elasticsearch-model/spec/elasticsearch/model/adapters/active_record/import_spec.rb‎`

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -52,6 +52,10 @@`
`52`	`52`	`it 'imports all documents' do`
`53`	`53`	`expect(ImportArticle.search('*').results.total).to eq(10)`
`54`	`54`	`end`
	`55`	`+`
	`56`	`+ it "does not pollute the model's namespace" do`
	`57`	`+ expect(ImportArticle.methods).not_to include(:__transform)`
	`58`	`+ end`
`55`	`59`	`end`
`56`	`60`
`57`	`61`	`context 'when batch size is specified' do`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit 4ee1708

File tree

1 file changed

1 file changed

`‎elasticsearch-model/spec/elasticsearch/model/adapters/active_record/import_spec.rb‎`

0 commit comments