-
Notifications
You must be signed in to change notification settings - Fork 238
feat: add ESM support for hapi #4702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 GitHub comments
Expand to view the GitHub comments
Just comment with:
rundocs-build: Re-trigger the docs validation. (use unformatted text in the comment!)
🔍 Preview links for changed docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Similarly to what #3381 did, I added ESM support for hapi.
It seems many tests are migrating to
runTestFixtures, so I followed that while trying to preserve the spirit of previous tests, hopefully it covers as much.I had some problems with the Windows CI when combined with ESM, I activated debugging for require-in-the-middle, there were traces up to hapi's
lib/server.js, but I never sawlib/index.jsin those traces, so I'm not sure what's happening there, it doesn't seem related to my changes.I guess this contributes a bit to #3445, I don't see the point of adding hapi (unscoped) support since it's been deprecated a very long while ago.
Checklist
docs/release-notes/index.md