-
Notifications
You must be signed in to change notification settings - Fork 908
Check for success before clearing form. #326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
ae27fbc
Ensure XHR success before clearing the form
mckennapsean 620bec4
Remove extraneous console logging
mckennapsean 0130608
Remove old honeypot function (dead code)
mckennapsean 2840e82
Merge branch 'master' into check-for-success
mckennapsean a609bf1
Merge branch 'master' into check-for-success
mckennapsean File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Remove extraneous console logging
Cleans up console output. Manual logging can be added by users themselves as desired.
- Loading branch information
commit 620bec4d9be352cc85f39cbc4e2dbf8bda546fca
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -57,7 +57,6 @@ | |
| formData.formGoogleSend | ||
| = form.dataset.email || ""; // no email by default | ||
|
|
||
| console.log(formData); | ||
| return {data: formData, honeypot}; | ||
| } | ||
|
|
||
|
|
@@ -79,8 +78,6 @@ | |
| // xhr.withCredentials = true; | ||
| xhr.setRequestHeader("Content-Type", "application/x-www-form-urlencoded"); | ||
| xhr.onreadystatechange = function() { | ||
| console.log(xhr.status, xhr.statusText); | ||
| console.log(xhr.responseText); | ||
| if (xhr.readyState === 4 && xhr.status === 200) { | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 |
||
| form.reset(); | ||
| var formElements = form.querySelector(".form-elements") | ||
|
|
@@ -101,7 +98,6 @@ | |
| } | ||
|
|
||
| function loaded() { | ||
| console.log("Contact form submission handler loaded successfully."); | ||
| // bind to the submit event of our form | ||
| var forms = document.querySelectorAll("form.gform"); | ||
| for (var i = 0; i < forms.length; i++) { | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.