Commit ae27fbc

committed

Ensure XHR success before clearing the form

Thanks to @tarasyarema for discovering the fix for this. Originally pulled from PR #315. Makes sure that the XHR request is completed and successful before clearing and hiding the form.

1 parent e5e01a8 commit ae27fbcCopy full SHA for ae27fbc

File tree

1 file changed

+10

-9

lines changed

form-submission-handler.js

1 file changed

+10

-9

lines changed

`‎form-submission-handler.js‎`

Lines changed: 10 additions & 9 deletions

Original file line number	Diff line number	Diff line change
`@@ -81,16 +81,17 @@`
`81`	`81`	`xhr.onreadystatechange = function() {`
`82`	`82`	`console.log(xhr.status, xhr.statusText);`
`83`	`83`	`console.log(xhr.responseText);`
`84`		`- form.reset();`
`85`		`- var formElements = form.querySelector(".form-elements")`
`86`		`- if (formElements) {`
`87`		`- formElements.style.display = "none"; // hide form`
`88`		`- }`
`89`		`- var thankYouMessage = form.querySelector(".thankyou_message");`
`90`		`- if (thankYouMessage) {`
`91`		`- thankYouMessage.style.display = "block";`
	`84`	`+ if (xhr.readyState === 4 && xhr.status === 200) {`
	`85`	`+ form.reset();`
	`86`	`+ var formElements = form.querySelector(".form-elements")`
	`87`	`+ if (formElements) {`
	`88`	`+ formElements.style.display = "none"; // hide form`
	`89`	`+ }`
	`90`	`+ var thankYouMessage = form.querySelector(".thankyou_message");`
	`91`	`+ if (thankYouMessage) {`
	`92`	`+ thankYouMessage.style.display = "block";`
	`93`	`+ }`
`92`	`94`	`}`
`93`		`- return;`
`94`	`95`	`};`
`95`	`96`	`// url encode form data for sending as post data`
`96`	`97`	`var encoded = Object.keys(data).map(function(k) {`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit ae27fbc

File tree

1 file changed

1 file changed

`‎form-submission-handler.js‎`

0 commit comments