Commit 50bb69b

committed

Ensure XHR success before clearing the form

Thanks to @tarasyarema for discovering the fix for this. Originally pulled from PR #315. Makes sure that the XHR request is completed and successful before clearing and hiding the form.

1 parent 7009d70 commit 50bb69bCopy full SHA for 50bb69b

File tree

1 file changed

+10

-9

lines changed

form-submission-handler.js

1 file changed

+10

-9

lines changed

`‎form-submission-handler.js‎`

Lines changed: 10 additions & 9 deletions

Original file line number	Diff line number	Diff line change
`@@ -86,16 +86,17 @@`
`86`	`86`	`xhr.onreadystatechange = function() {`
`87`	`87`	`console.log(xhr.status, xhr.statusText);`
`88`	`88`	`console.log(xhr.responseText);`
`89`		`- form.reset();`
`90`		`- var formElements = form.querySelector(".form-elements")`
`91`		`- if (formElements) {`
`92`		`- formElements.style.display = "none"; // hide form`
	`89`	`+ if (xhr.readyState === 4 && xhr.status === 200) {`
	`90`	`+ form.reset();`
	`91`	`+ var formElements = form.querySelector(".form-elements")`
	`92`	`+ if (formElements) {`
	`93`	`+ formElements.style.display = "none"; // hide form`
	`94`	`+ }`
	`95`	`+ var thankYouMessage = form.querySelector(".thankyou_message");`
	`96`	`+ if (thankYouMessage) {`
	`97`	`+ thankYouMessage.style.display = "block";`
	`98`	`+ }`
`93`	`99`	`}`
`94`		`- var thankYouMessage = form.querySelector(".thankyou_message");`
`95`		`- if (thankYouMessage) {`
`96`		`- thankYouMessage.style.display = "block";`
`97`		`- }`
`98`		`- return;`
`99`	`100`	`};`
`100`	`101`	`// url encode form data for sending as post data`
`101`	`102`	`var encoded = Object.keys(data).map(function(k) {`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit 50bb69b

File tree

1 file changed

1 file changed

`‎form-submission-handler.js‎`

0 commit comments