Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commit 1ea724e

Browse files
Merge pull request #327 from dwyl/remove-unnecessary-validation
Remove unnecessary form validation for email
2 parents 7009d70 + da0ed64 commit 1ea724e

File tree

3 files changed

+25
-42
lines changed

3 files changed

+25
-42
lines changed

‎form-submission-handler.js‎

Lines changed: 25 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,4 @@
11
(function() {
2-
function validEmail(email) {
3-
var re = /^([\w-]+(?:\.[\w-]+)*)@((?:[\w-]+\.)*\w[\w-]{0,66})\.([a-z]{2,6}(?:\.[a-z]{2})?)$/i;
4-
return re.test(email);
5-
}
6-
72
function validateHuman(honeypot) {
83
if (honeypot) { //if hidden form filled up
94
console.log("Robot Detected!");
@@ -70,39 +65,31 @@
7065
}
7166
*/
7267

73-
if( data.email && !validEmail(data.email) ) { // if email is not valid show error
74-
var invalidEmail = form.querySelector(".email-invalid");
75-
if (invalidEmail) {
76-
invalidEmail.style.display = "block";
77-
return false;
78-
}
79-
} else {
80-
disableAllButtons(form);
81-
var url = form.action;
82-
var xhr = new XMLHttpRequest();
83-
xhr.open('POST', url);
84-
// xhr.withCredentials = true;
85-
xhr.setRequestHeader("Content-Type", "application/x-www-form-urlencoded");
86-
xhr.onreadystatechange = function() {
87-
console.log(xhr.status, xhr.statusText);
88-
console.log(xhr.responseText);
89-
form.reset();
90-
var formElements = form.querySelector(".form-elements")
91-
if (formElements) {
92-
formElements.style.display = "none"; // hide form
93-
}
94-
var thankYouMessage = form.querySelector(".thankyou_message");
95-
if (thankYouMessage) {
96-
thankYouMessage.style.display = "block";
97-
}
98-
return;
99-
};
100-
// url encode form data for sending as post data
101-
var encoded = Object.keys(data).map(function(k) {
102-
return encodeURIComponent(k) + "=" + encodeURIComponent(data[k]);
103-
}).join('&');
104-
xhr.send(encoded);
105-
}
68+
disableAllButtons(form);
69+
var url = form.action;
70+
var xhr = new XMLHttpRequest();
71+
xhr.open('POST', url);
72+
// xhr.withCredentials = true;
73+
xhr.setRequestHeader("Content-Type", "application/x-www-form-urlencoded");
74+
xhr.onreadystatechange = function() {
75+
console.log(xhr.status, xhr.statusText);
76+
console.log(xhr.responseText);
77+
form.reset();
78+
var formElements = form.querySelector(".form-elements")
79+
if (formElements) {
80+
formElements.style.display = "none"; // hide form
81+
}
82+
var thankYouMessage = form.querySelector(".thankyou_message");
83+
if (thankYouMessage) {
84+
thankYouMessage.style.display = "block";
85+
}
86+
return;
87+
};
88+
// url encode form data for sending as post data
89+
var encoded = Object.keys(data).map(function(k) {
90+
return encodeURIComponent(k) + "=" + encodeURIComponent(data[k]);
91+
}).join('&');
92+
xhr.send(encoded);
10693
}
10794

10895
function loaded() {

‎index.html‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,6 @@ <h2 class="content-head is-center">Contact Us!</h2>
4343
<label for="email"><em>Your</em> Email Address:</label>
4444
<input id="email" name="email" type="email" value=""
4545
required placeholder="your.name@email.com"/>
46-
<span class="email-invalid" style="display:none">
47-
Must be a valid email address</span>
4846
</fieldset>
4947

5048
<fieldset class="pure-group">

‎test.html‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -222,8 +222,6 @@ <h2><em>Thanks</em> for contacting us!
222222
<label for="email"><em>Your</em> Email Address:</label>
223223
<input id="email" name="email" type="email" value=""
224224
required placeholder="your.name@email.com"/>
225-
<span class="email-invalid" style="display:none">
226-
Must be a valid email address</span>
227225
</fieldset>
228226

229227
<fieldset class="pure-group">

0 commit comments

Comments
(0)

AltStyle によって変換されたページ (->オリジナル) /