-
Notifications
You must be signed in to change notification settings - Fork 10.5k
How do I get someone to look at my PR? #63563
-
I submitted a PR in May (#61947) and it seems that no one has looked at it (or at least commented on it). I just recently got an SME to provide feedback, but I had to go to them directly and ask for their review. I understand that may be required in cases where the SME is not as active in the project.
At this point, I'm not sure if I am supposed to be doing something else to flag my PR as ready for review (I see other PRs getting comments and traction). I didn't see anything in the contribution guidelines indicating specific steps. So, I'm reaching out to the community to ask for advice on how to get some eyes on my PR. Any advice is welcome!
Beta Was this translation helpful? Give feedback.
All reactions
Replies: 1 comment 3 replies
-
It might not be why it hasn't had reviews from the ASP.NET Core team to-date, but I see that your PR adds new API surface area and the PR (or the referenced issue) doesn't seem to link to a issue for an approved API review to add those members (see the API proposal issue template), which would be a blocker to it being merged.
Beta Was this translation helpful? Give feedback.
All reactions
-
❤️ 1
-
I really appreciate your response. I see the API proposal template has the label api-suggestion. Is there a way I can get that label added, or do you think it's better for me to create a new issue and link back to the original and the PR?
Beta Was this translation helpful? Give feedback.
All reactions
-
It's probably best to go with an issue, as there's a specific template for it with the require information for when it's reviewed by the team.
Beta Was this translation helpful? Give feedback.
All reactions
-
I created a new issue specifically for the API change (#63566). I appreciate your help and quick responses!
Beta Was this translation helpful? Give feedback.
All reactions
-
❤️ 1