Commit 93a8d4b

committed

Do not retrieve the number of contours for empty glyphs

Before this change php-font-lib always read the number of contours for a glyph. If a glyph has no data the read information would be incorrect. This could lead to invalid parsing of the glyph since the data may not represent the actual glyph format (simple). In fact, the data could be from outside the glyf table entirely. If the glyph was positioned as the last byte in the font a read error would be thrown.

1 parent a5c850b commit 93a8d4bCopy full SHA for 93a8d4b

File tree

1 file changed

-1

lines changed

src/FontLib/Glyph
- Outline.php

1 file changed

-1

lines changed

`‎src/FontLib/Glyph/Outline.php‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,7 @@ class Outline extends BinaryStream {`
`48`	`48`	`static function init(glyf $table, $offset, $size, BinaryStream $font) {`
`49`	`49`	`$font->seek($offset);`
`50`	`50`
`51`		`- if ($font->readInt16() > -1) {`
	`51`	`+ if ($size === 0 \|\| $font->readInt16() > -1) {`
`52`	`52`	`/** @var OutlineSimple $glyph */`
`53`	`53`	`$glyph = new OutlineSimple($table, $offset, $size);`
`54`	`54`	`}`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit 93a8d4b

File tree

1 file changed

1 file changed

`‎src/FontLib/Glyph/Outline.php‎`

0 commit comments