Commit 652ea1f

committed

Use simpler, spec-compliat checksum logic

Per the spec: > Table checksums are the unsigned sum of the longs in a table.

1 parent e6336d1 commit 652ea1fCopy full SHA for 652ea1f

File tree

-14

lines changed

-14

lines changed

Lines changed: 2 additions & 14 deletions

Original file line number	Diff line number	Diff line change
`@@ -49,20 +49,8 @@ static function computeChecksum($data) {`
`49`	`49`	`$data = str_pad($data, $len + (4 - $mod), "0円");`
`50`	`50`	`}`
`51`	`51`
`52`		`- $len = mb_strlen($data, '8bit');`
`53`		`-`
`54`		`- $hi = 0x0000;`
`55`		`- $lo = 0x0000;`
`56`		`-`
`57`		`- for ($i = 0; $i < $len; $i += 4) {`
`58`		`- $hi += (ord($data[$i]) << 8) + ord($data[$i + 1]);`
`59`		`- $lo += (ord($data[$i + 2]) << 8) + ord($data[$i + 3]);`
`60`		`- $hi += $lo >> 16;`
`61`		`- $lo = $lo & 0xFFFF;`
`62`		`- $hi = $hi & 0xFFFF;`
`63`		`- }`
`64`		`-`
`65`		`- return ($hi << 8) + $lo;`
	`52`	`+ $table = unpack("N*", $data);`
	`53`	`+ return array_sum($table);`
`66`	`54`	`}`
`67`	`55`
`68`	`56`	`function __construct(File $font) {`

Comments

(0)