✨ Allow for specifying the S3 Storage Class #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

Schlepptop wants to merge 14 commits into dokku:master

from Schlepptop:master

Open

✨ Allow for specifying the S3 Storage Class #205

Schlepptop wants to merge 14 commits into dokku:master from Schlepptop:master

Conversation

@Schlepptop

Copy link

@Schlepptop Schlepptop commented Jul 14, 2020

Requires that dokku/docker-s3backup#12 be merged

schlepptop added 9 commits

July 14, 2020 02:28


 ✨ Allow for specifying the S3 Storage Class

565ad35

Requires that dokku/docker-s3backup#12 be merged


 📝

05da386


 🐛

347195c


 🐛

6c09e3d


 🐛 Create /backup only if it doesn't exist

812619d


 ⬆️ Upgrade s3backup dependency to 11.0

001dff3


 ⬆️ Upgrade s3backup dependency to 11.1

6b96fdd


 🐛 wrong case

114593b


 🐛 Missing $

3e78949

josegonzalez

josegonzalez reviewed

Jul 14, 2020

View reviewed changes

common-functions

rm -f "$SERVICE_BACKUP_ROOT/AWS_SECRET_ACCESS_KEY"

rm -f "$SERVICE_BACKUP_ROOT/AWS_DEFAULT_REGION"

rm -f "$SERVICE_BACKUP_ROOT/AWS_SIGNATURE_VERSION"

rm -f "$SERVICE_BACKUP_ROOT/ENDPOINT_URL"

Copy link

Member

@josegonzalez josegonzalez Jul 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change?

Copy link

Author

@Schlepptop Schlepptop Jul 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the auth command is no longer the only one using that directory, leaving it the way it was would also delete the S3_STORAGE_CLASS.

common-functions

local SERVICE_BACKUP_ROOT="$PLUGIN_DATA_ROOT/$SERVICE/backup"

mkdir "$SERVICE_BACKUP_ROOT"

mkdir -p "$SERVICE_BACKUP_ROOT"

Copy link

Member

@josegonzalez josegonzalez Jul 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this necessary?

Copy link

Author

@Schlepptop Schlepptop Jul 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise it will fail upon trying to create the dir if it already existed

README.md Outdated

postgres:backup <service> <bucket-name> [--use-iam] # creates a backup of the postgres service to an existing s3 bucket

postgres:backup-auth <service> <aws-access-key-id> <aws-secret-access-key> <aws-default-region> <aws-signature-version> <endpoint-url> # sets up authentication for backups on the postgres service

postgres:backup-deauth <service> # removes backup authentication for the postgres service

postgres:backup-s3class <service> <s> <-storage-class> # sets the S3 storage class to be used for backups on the postgres service

Copy link

Member

@josegonzalez josegonzalez Jul 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you manually regenerate the readme via make README.md?

Copy link

Author

@Schlepptop Schlepptop Jul 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the way it generates, I can fix the output but idk if there's an issue with the parsing or my subcommand.

common-functions Outdated

local SERVICE_BACKUP_ROOT="$PLUGIN_DATA_ROOT/$SERVICE/backup/"

mkdir -p "$SERVICE_BACKUP_ROOT"

echo "$S3_STORAGE_CLASS" >"$SERVICE_BACKUP_ROOT/S3_STORAGE_CLASS"

Copy link

Member

@josegonzalez josegonzalez Jul 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really need to transfer all of this to the new properties system...

schlepptop added 5 commits

July 15, 2020 02:03


 📝 Allow for correctly generating the README.md

a212e19


 Confirm change

b6325b4


 ♻️ Use properties system instead of /backup directory

5e2662e


 🐛

1d027ba


 🐛

b820322

Labels

None yet

2 participants

@Schlepptop @josegonzalez

Uh oh!

✨ Allow for specifying the S3 Storage Class #205

Are you sure you want to change the base?

✨ Allow for specifying the S3 Storage Class #205

Uh oh!

Conversation

@Schlepptop Schlepptop commented Jul 14, 2020

Uh oh!

@josegonzalez josegonzalez Jul 14, 2020

Choose a reason for hiding this comment

Uh oh!

@Schlepptop Schlepptop Jul 14, 2020

Choose a reason for hiding this comment

Uh oh!

@josegonzalez josegonzalez Jul 14, 2020

Choose a reason for hiding this comment

Uh oh!

@Schlepptop Schlepptop Jul 14, 2020

Choose a reason for hiding this comment

Uh oh!

@josegonzalez josegonzalez Jul 14, 2020

Choose a reason for hiding this comment

Uh oh!

@Schlepptop Schlepptop Jul 14, 2020

Choose a reason for hiding this comment

Uh oh!

@josegonzalez josegonzalez Jul 14, 2020

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants