-
Notifications
You must be signed in to change notification settings - Fork 2
Fixture/update config files #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Makefile
Outdated
@jkernech
jkernech
Aug 20, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use sonar-scanner here as well, sonar-runner is deprecated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tests are failing
@jkernech
jkernech
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests need to be fixed
78b8312 to
7725ea7
Compare
Fixed this but I was not able to fix sonar with ciircleCi2 so I left it commented (some permission error on exec).
d55dacd to
e09d465
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you are lacking env variables here. That's why it was failing with some permission errors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
they are set up in the ENV section on circle ci page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as the ones for SWS s3 which work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also please include the .circleci folder to the .npmignore?
- Add sonar badges into README.md Closes #7 - Add npm run rules - Replace istanbul by nyc - Add circleci v2 config - Sonar to scanner
e09d465 to
2a62b5f
Compare
@Spring3 done!
Mihovil is now the asinee
Npm audit found 0 vulnerabilities
Modify rules command of package.json and Makefile