Commit 6899f08

vgeorgekylebarron

and

authored

feat: add pytest-ipywidgets bbox testing, remove playwright (#999)

## Summary Add pytest-ipywidgets for browser-based bbox interaction testing and remove Playwright/Vitest infrastructure. ## Changes - Add `tests/ui/test_bbox_interaction.py` with complete bbox workflow testing - Add pytest-ipywidgets>=1.54.0 dependency - Remove all Playwright tests, configs, and dependencies - Remove Vitest testing infrastructure - Update GitHub Actions workflow to focus on build and lint ## Benefits - Faster widget-level testing vs full E2E - Better debugging with console access - Simplified maintenance with single test file - Same bbox interaction validation maintained ## Related Issues - Fixes #524 - Automated widget testing - Replaces #928 - Playwright CI testing --------- Co-authored-by: Kyle Barron <kyle@developmentseed.org>

1 parent 77bb3a0 commit 6899f08Copy full SHA for 6899f08

File tree

23 files changed

+2491

-3852

lines changed

.github/workflows
- test-js.yml
- test.yml
package-lock.json
package.json
playwright.config.ts
pyproject.toml
src
- index.tsx
tests
- e2e
  - README.md
  - bbox-select-overlay.spec.ts
  - bbox-select.spec.ts
  - fixtures
    - simple-map.ipynb
  - helpers
    - assertions.ts
    - deckgl
    - maplibre.ts
    - notebook.ts
  - notebook-load.spec.ts
- ui
uv.lock
vitest.config.ts

23 files changed

+2491

-3852

lines changed

`‎.github/workflows/test-js.yml‎`

Lines changed: 2 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-name: CI`
	`1`	`+name: JavaScript Build and Lint`
`2`	`2`
`3`	`3`	`on:`
`4`	`4`	`push:`
`@@ -11,7 +11,7 @@ concurrency:`
`11`	`11`	`cancel-in-progress: true`
`12`	`12`
`13`	`13`	`jobs:`
`14`		`- lint-and-test:`
	`14`	`+ build-and-lint:`
`15`	`15`	`runs-on: ubuntu-latest`
`16`	`16`
`17`	`17`	`steps:`
`@@ -42,6 +42,3 @@ jobs:`
`42`	`42`
`43`	`43`	`- name: Lint check`
`44`	`44`	`run: npm run lint`
`45`		`-`
`46`		`- - name: Test`
`47`		`- run: npm run test`

`‎.github/workflows/test.yml‎`

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -59,6 +59,10 @@ jobs:`
`59`	`59`	`run: \|`
`60`	`60`	`npm run build`
`61`	`61`
	`62`	`+ - name: Install Playwright browsers`
	`63`	`+ run: \|`
	`64`	`+ uv run playwright install chromium`
	`65`	`+`
`62`	`66`	`- name: Run tests`
`63`	`67`	`run: uv run pytest`
`64`	`68`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit 6899f08

File tree

23 files changed

23 files changed

`‎.github/workflows/test-js.yml‎`

`‎.github/workflows/test.yml‎`

0 commit comments