Commit bfb0766

alexmarkovCommit Queue

authored and

Commit Queue

committed

[vm] Fix msvc product build

Fixes the following build error: ``` libdart_vm_precompiler.profiler.obj : error LNK2019: unresolved external symbol "public: static class dart::Sample * __cdecl dart::SampleBlock::ReserveSampleAndLink(class dart::Sample *,class dart::Isolate *)" (?ReserveSampleAndLink@SampleBlock@dart@@SAPEAVSample@2@PEAV32@PEAVIsolate@2@@z) referenced in function "public: bool __cdecl dart::ProfilerStackWalker::Append(unsigned __int64,unsigned __int64)" (?Append@ProfilerStackWalker@dart@@QEAA_N_K0@Z) ``` TEST=vm-msvc-win-x64-try, vm-msvc-win-arm64-try Change-Id: I0819a15c6201deb7933ebe01690a80e8d083134d Cq-Include-Trybots: luci.dart.try:vm-msvc-win-arm64-try,vm-msvc-win-x64-try Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/460140 Auto-Submit: Alexander Markov <alexmarkov@google.com> Reviewed-by: Alexander Aprelev <aam@google.com> Commit-Queue: Alexander Aprelev <aam@google.com>

1 parent 29d09ed commit bfb0766Copy full SHA for bfb0766

File tree

1 file changed

-0

lines changed

runtime/vm
- profiler.cc

1 file changed

-0

lines changed

`‎runtime/vm/profiler.cc‎`

Lines changed: 6 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -15,6 +15,7 @@`
`15`	`15`	`#include "vm/compiler/compiler_state.h"`
`16`	`16`	`#endif`
`17`	`17`	`#include "vm/debugger.h"`
	`18`	`+#include "vm/globals.h"`
`18`	`19`	`#include "vm/heap/safepoint.h"`
`19`	`20`	`#include "vm/instructions.h"`
`20`	`21`	`#include "vm/isolate.h"`
`@@ -158,6 +159,7 @@ class ProfilerStackWalker : public ValueObject {`
`158`	`159`	`total_frames_++;`
`159`	`160`	`return true;`
`160`	`161`	`}`
	`162`	`+#if defined(DART_INCLUDE_PROFILER)`
`161`	`163`	`if (total_frames_ >= FLAG_max_profile_depth) {`
`162`	`164`	`sample_->set_truncated_trace(true);`
`163`	`165`	`return false;`
`@@ -178,6 +180,10 @@ class ProfilerStackWalker : public ValueObject {`
`178`	`180`	`frame_index_++;`
`179`	`181`	`total_frames_++;`
`180`	`182`	`return true;`
	`183`	`+#else`
	`184`	`+ UNREACHABLE();`
	`185`	`+ return false;`
	`186`	`+#endif`
`181`	`187`	`}`
`182`	`188`
`183`	`189`	`protected:`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit bfb0766

File tree

1 file changed

1 file changed

`‎runtime/vm/profiler.cc‎`

0 commit comments